Comments

JeroenT created an issue. See original summary.

jeroent’s picture

Status: Active » Postponed
StatusFileSize
new1.54 KB
jeroent’s picture

StatusFileSize
new1.8 KB
berdir’s picture

Unsure how to best approach this. Removing requirements on drupal modules is really awkward, your site is broken if this was the only reason you had ctools.

So I'm unsure about dropping it without also doing a major new version or something.

Idea: We remove it from .info.yml but keep it in composer, then the code won't vanish on existing sites and if you feel strongly about not having the code you can do a replace definition in composer.json. And then we can remove it some time later, maybe as an eventual 2.x release...

berdir’s picture

Status: Postponed » Needs work

Note: I've included this in #3266631: Drupal 10 compatibility, require Drupal 9.3 to test against D10, will likely still commit here with the suggested approach above later on.

wells’s picture

@Berdir I think the idea in #4 is reasonable. Could the ctools dependency even be moved to suggest? I'm not sure if that would work the same way or not...

berdir’s picture

Status: Needs work » Needs review
StatusFileSize
new1.27 KB

A suggest would still require manual intervention, that's something I want to avoid in a minor update. Rerolled the patch and removed the composer.info snippet.

If you really don't want ctools in your project code base, then you could add this to your composer.info.yml:

   "replace": {
        "drupal/ctools": "*"
    },

But I think most projects won't care about that.

  • Berdir committed bb2556d on 8.x-1.x authored by JeroenT
    Issue #3222775 by JeroenT, Berdir: Remove dependency on CTools
    
berdir’s picture

Status: Needs review » Fixed

Committed this!

  • Berdir committed 31d8bb1 on 8.x-1.x
    Revert "Issue #3222775 by JeroenT, Berdir: Remove dependency on CTools...
berdir’s picture

Status: Fixed » Needs review

Aw, I forgot about the core version requirement that comes with this. Reverted until we require Drupal 9.3. I might just merge this together with #3266631: Drupal 10 compatibility, require Drupal 9.3 after all.

chris matthews’s picture

Thanks for the work on this issue. Just to confirm, once either 31d8bb1 is re-committed under this issue, or committed under #3266631: Drupal 10 compatibility, require Drupal 9.3 and Pathauto 8.x-1.10 is tagged, after I update my codebase to 8.x-1.10 I can simply uninstall ctools, correct?

sd123’s picture

Uninstalling ctools does not seem to be possible on my installation. It still says there is a dependency on pathauto. I am running Drupal 9.3.12 and 8.x-1.10.

berdir’s picture

The release notes need to be read as preparation for "Drupal 10 and removal of ctools dependency". It's neither drupal 10 compatible nor ctools-free *yet*.

sd123’s picture

Ok, that was not clear to me. It looked to me like "preparation for Drupal 10" + "removal of ctools dependency".

berdir’s picture

StatusFileSize
new1.44 KB

Updated patch to require Drupal 9.3.

  • Berdir committed 0bb2e94 on 8.x-1.x
    Issue #3222775 by Berdir, JeroenT: Remove dependency on CTools
    
berdir’s picture

Status: Needs review » Fixed

Committed.

klemendev’s picture

Any plans for a release with this feature?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

klemendev’s picture

This was not really fixed

chris matthews’s picture

StatusFileSize
new97.22 KB

@KlemenDEV, this was fixed in commit 0bb2e94 on 8.x-1.x-dev, pending a 8.x-1.11 tagged release.

3222775

klemendev’s picture

Thanks for the heads-up, did not notice the merge :)

sanduhrs’s picture

The dependency is still present in the custom composer.json as a requirement:
https://git.drupalcode.org/project/pathauto/-/blob/8.x-1.x/composer.json...

berdir’s picture

Yes. the release notes explain why that is there.