Problem/Motivation

Tests are failing in various versions of Drupal and PHP higher than the versions configured for automated test.

Steps to reproduce

Run tests against Drupal 9.3 / PHP 8

Proposed resolution

  • Fix tests
  • Enable automated testing against Drupal 9.3 / PHP 8
CommentFileSizeAuthor
#5 interdiff-3-5.txt1.68 KBmstrelan
#5 3221617-5.patch7.57 KBmstrelan
#3 3221617-3.patch871 bytesmstrelan
#2 3221617-2-test-only.patch303 bytesmstrelan

Issue fork entity_embed-3221617

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan’s picture

mstrelan commented
StatusFileSize
new 3221617-2-test-only.patch303 bytes

Adding a test-only patch to trigger tests.

mstrelan’s picture

mstrelan commented
Status: Active » Needs work
StatusFileSize
new 3221617-3.patch871 bytes

This should fix the failures in PHP 8. There are still some failures related to testing on Drupal 9.

mstrelan’s picture

mstrelan commented

There are some additional fails now in 9.3. Seems that some URLs that were previously absolute in 9.2.x are now relative in 9.3.x. I haven't updated the tests to accommodate this because I'm not sure if the change was intentional.

mstrelan’s picture

mstrelan commented
Title: Enable automatic tests for PHP 8 » Tests failing in Drupal 9.3.x, PHP 8
Category: Task » Bug report
Issue summary: View changes
StatusFileSize
new 3221617-5.patch7.57 KB
new interdiff-3-5.txt1.68 KB

The fails from 9.3 were related to #2669074: Convert file_create_url() & file_url_transform_relative() to service, deprecate it. Checking for an relative URL should work in older and newer versions. The two deprecated functions need to remain until Drupal 9.2 is no longer supported.

PHP 8 also complains about the sRGB profile of the CKEditor button image. I converted the image with Imagemagick and it's now about 10% of the size and PHP no longer complains.

I think the only outstanding issue will be the UpdateHookTest which I haven't looked at yet. I suspect the fixture is too old for Drupal 9. It might need to be recreated in Drupal 8.9.

phenaproxima made their first commit to this issue’s fork.

phenaproxima opened merge request !1

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

Hiding patches in favor of the merge request.

  • phenaproxima committed 9a059b0 on 8.x-1.x 
    Issue #3221617 by phenaproxima, mstrelan: Tests failing in Drupal 9.3.x...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Fixed

I'm satisfied. Fixed in 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.