Tests are failing for drupal 9

Some deprecations affects drupal 9 compatibility. Review and fix

CommentFileSizeAuthor
#10 3219887-10.patch3.24 KBandras_szilagyi
#9 3219887-9.patch3.23 KBandras_szilagyi
#7 3219887-7.patch3.31 KBandras_szilagyi

Issue fork contact_storage_export-3219887

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

escuriola created an issue. See original summary.

escuriola opened merge request !2

escuriola opened merge request !3

escuriola closed merge request !2

escuriola’s picture

escuriola commented
Status: Active » Needs review
andras_szilagyi’s picture

andras_szilagyi commented

Other than my question above it looks good and works

andras_szilagyi’s picture

andras_szilagyi commented
StatusFileSize
new 3219887-7.patch3.31 KB

I'm uploading a patch, the reason is that I don't think the core constraints have to be changed in this issue, and for a reason I dont understand I cant push to the MR

andras_szilagyi’s picture

andras_szilagyi commented
Status: Needs review » Reviewed & tested by the community

I made the patch to go forward but please do credit @escuriola

andras_szilagyi’s picture

andras_szilagyi commented
StatusFileSize
new 3219887-9.patch3.23 KB
andras_szilagyi’s picture

andras_szilagyi commented
StatusFileSize
new 3219887-10.patch3.24 KB

the strange branch name gave me quirky git behaviour, need to upload another patch

scott_euser’s picture

scott_euser commented
Status: Reviewed & tested by the community » Fixed

Thank you both!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.