Problem/Motivation

After enabling the module, If i want to disable auto logout for sometime I have to uninstall the module.

Proposed resolution

There should be a boolean checkbox on Module configuration page "/admin/config/people/autologout", for asking enable functionality.
If use tick on enable then module will work for auto logout in case untick module should not autolog.

if checkbox is untick there should be a warning message as well "You need to tick checkbox for enabling the autologout functionality"

CommentFileSizeAuthor
#3 3219414-3.patch2.74 KBlarisse
#2 3219414-2.patch2.14 KBlarisse

Issue fork autologout-3219414

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rajveergang created an issue. See original summary.

larisse’s picture

larisse commented
Status: Active » Needs review
StatusFileSize
new 3219414-2.patch2.14 KB

Hi!
I think this patch can provide this feature. Could you test, please?

larisse’s picture

larisse commented
StatusFileSize
new 3219414-3.patch2.74 KB

Just making a patch best and fixing some coding standards messages.

gombi made their first commit to this issue’s fork.

gombi’s picture

gombi commented
Assigned: Unassigned » gombi
Status: Needs review » Active

The proposed patch adds the option to disable autologout for a specific user on their profile settings. While I don't necessarily think this is a bad idea, the issue is asking for the option on the module configuration page (/admin/config/people/autologout), to allow disabling/enabling autologout for all users.

I'm working on implementing this.

rajveergangwar’s picture

rajveergangwar
Primary language English
Location Delhi
commented

Hi Gombi,

The idea it to implement the enable disable functionality of autologout without uninstalling the module.

For some cases there may need to stop autologout for a while, so disable only should be the good approch instead the uninstall the module.

So internally module will enabled and installed in the drupal system but it will work when autologout active checkbox (which we are thiniking to implement on the config page of the module) is ticked otherwise it will not work.

gombi’s picture

gombi commented
Assigned: gombi » Unassigned

Hi rajveergang,

that's the implementation I was working on. I'm unassigning this for now, however, as I'm not sure when I'll be able to continue working on this issue.

gombi opened merge request !11

gombi’s picture

gombi commented
Status: Active » Needs review

I have added an option to enable/disable autologout on its settings page. Should be ready for review.

rajveergangwar’s picture

rajveergangwar
Primary language English
Location Delhi
commented

Hi @gombi,
Which branch or patch should I test it ?

gombi’s picture

gombi commented

Hi @rajveergang,

the changes are available on the issue fork here: https://git.drupalcode.org/issue/autologout-3219414/-/tree/3219414-modul...

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Reviewed & tested by the community

This needs an update hook to add the default value of enabled. Otherwise this is good to go. I've committed the changes to the 8.x-1.4 release issue: #3293639: Issues for 8.x-1.4 release

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

  • japerry committed 765055a on 8.x-1.x authored by gombi 
    Issue #3219414: Module should have enable and disable checkbox on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.