Problem/Motivation

Entity Reference Module is removed in Drupal 9

Proposed resolution

Remove entity_reference from the dependencies and update the core compatibility to Drupal > 8.8 | 9 only.

Issue fork oauth2_server-3218576

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dwkitchen created an issue. See original summary.

dwkitchen opened merge request !2

dwkitchen’s picture

dwkitchen commented
Status: Active » Needs review
jatin12nov’s picture

jatin12nov
Primary language English
commented

I fails with 9.1.11.

Error: Error: Interface 'OAuth2\OpenID\Storage\AuthorizationCodeInterface' not found in include() (line 19 of /app/docroot/modules/contrib/oauth2_server/src/OAuth2StorageInterface.php)

cafuego’s picture

cafuego commented
Status: Needs review » Closed (duplicate)

This is a duplicate issue, closing in favour of #3187764: Module uninstalled during upgrade to Drupal 9 due to entity_reference.

dwkitchen’s picture

dwkitchen commented
Issue summary: View changes
Status: Closed (duplicate) » Needs review

I have re-opened this issue as the patch here is more complete than the one on #3187764: Module uninstalled during upgrade to Drupal 9 due to entity_reference as it fails tests.

fjgarlin’s picture

fjgarlin commented
Status: Needs review » Reviewed & tested by the community

This was blocking my update to D9.2.5, all driven by composer. After applying the patch, everything went through without issues.
Marking as RTBC.

gapple’s picture

gapple
he/they
Primary language English
commented

I don't see a reason to remove compatibility with 8?
Not having a release that's marked as compatible with both D8.9 and D9 makes updating a site additional effort.

fjgarlin’s picture

fjgarlin commented

Agree, added D8 compatibility back which should make easier updates from D8 to D9. I didn't know that the edits would go against the fork branch directly, but it's a small change so hopefully it will be ok.

dwkitchen’s picture

dwkitchen commented
Status: Reviewed & tested by the community » Needs work

By removing the dependency on entity_reference, the module is no longer compatible with Drupal 8.

fjgarlin’s picture

fjgarlin commented

My understanding is that the module's code was fully extracted and moved to core long ago (https://git.drupalcode.org/project/drupal/-/blob/8.8.x/core/modules/enti...), so it should be safe to disable that module.

I think it is actually part of the D9 update hooks (https://git.drupalcode.org/project/drupal/-/blob/9.3.x/core/modules/syst...)

I'm not entirely sure how it's breaking compatibility with D8.

dwkitchen’s picture

dwkitchen commented
Status: Needs work » Reviewed & tested by the community

Ah, that's how we did it, the module was left in but didn't do anything.

We could have removed the dependency long ago!

dwkitchen’s picture

dwkitchen commented
Issue summary: View changes

  • sanduhrs committed a8cc769 on 2.0.x authored by dwkitchen 
    Issue #3218576: Remove entity reference dependency for Drupal 9
sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented
Status: Reviewed & tested by the community » Fixed

Great, thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.