Meeting of the Bug Smash Initiative 2021-06-22 [#3218058]

Agenda items

Standing items

Who is here
Any other suggested topics
Wins / Thanks / Blockers
Statistics and functionality update. X new bugs created in last two weeks. Y closed by the initiative.
The bug I would most like to see fixed
Update on target items from last meeting
What should be the initiative focus for the next 2 weeks?

Statistics

ToDos

Request new initiative page is added to the menu. - quietone

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.

Indrajith KB	Indrajith from Kerala, India.
quietone	Vicki, NZ
larowlan	Lee .au
kimb0	Kim AU
Griffyn Heels	Griff, AU
mohit_aghera	Mohit, India.
gaurav mahlawat	Gauravmahlawat, India
jibran	Jibran, AU
Neslee	Neslee, Valencia
Spokje	Frank NL
lendude	Len, Amsterdam
Kunal Kapoor	kunalkapoor, India
anjalivijay	Anjali, India
Matroskeen	Ivan, Ukraine (catching up in the morning :sunflower:) (edited)
mansoor20	Mansoor, India :wave:
hansa11	Hello :wave:Hansa, India
Guilherme Vitoriano Pereira	Guilherme, Brazil! :wave::skin-tone-5:
Paulo Henrique Cota Starling	Paulo, Brazil!

0️⃣.5️⃣ What's your favourite sporting team or sports person? Who do you support?

larowlan	Australian women's cricket team :cricket_bat_and_ball:
quietone	John Kirwan
Griffyn Heels	I'm a big Sydney Swans :swan: fan (edited)
jibran	Fav Game: Drupal Core commit count.Fav Team: Core committer team.
Matroskeen	There is no favourite one, but currently supporting Ukrainian national football team on UEFA EURO 2020 :soccer:
Guilherme Vitoriano Pereira	Fav team: Sport Club Corinthians Paulista :soccer:Fav player: Socrates :soccer:
Paulo Henrique Cota Starling	As I'm Brazilian, of course it is football.I support the biggest in Brazil... Cruzeiro Esporte Clubehttps://www.youtube.com/watch?v=PerGilCmwbQ

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

larowlan	9.2 testing. Anyone had an issues updating?
mohit_aghera	Not particular discussion, but an update:I’ve submitted Bugsmash initiative keynote session along with @Spokje
kimb0	PHP8 compatibility for contrib
quietone	Approval to add the new initiative page to the menu, https://www.drupal.org/node/3215948
quietone	What changes have you noticed in the Bug Reports, https://www.drupal.org/project/issues/search/drupal?project_issue_follow...…]1&version%5B%5D=any_9.&version%5B%5D=any_8.&issue_tags_op=%3D
larowlan	Should we discuss what constitutes attendance at meetings in terms of qualifying for issue credits?

2️⃣.1️⃣ Wins - what wins have you had since the last meeting? Share your successes! (edited)

larowlan	Had some time for the RTBC queue
mohit_aghera	#2927874: Comment preview form shows parent entity before action buttons - FixedAnd a few more RTBC
quietone	#2228087: PhpStreamWrapperInterface lacks docblocks - Fixed
larowlan	These are both on my list :face_with_cowboy_hat:
Spokje	Just wanted to state I see it as a win that this Initiative has meetings where a lot of different topics/issues/ideas pop-up/are talked about.No clue if other Initiative meetings do this (I come there only to say hi and harvest credits... :smiling_imp:) but I really learn a lot in here, not only about smashing critters.
Guilherme Vitoriano Pereira	Found time to work in one or too BS issues...
Matroskeen	Four migrate issues I was helping out were marked as “Fixed” within the last hour :exploding_head:#3209353: Add documentation for remaining node and taxonomy modules@jibran’s favourite team is on fire! (edited)

2️⃣.2️⃣ Thanks - a space for callouts to other contributors who’ve helped you

mohit_aghera	Periodic thanks to all the amazing contributors and mentors like @larowlan @quietone @jibran @lendude @dww.
larowlan	Right back at you
jibran	Did I do anything this fortnightly? :D (edited)
Spokje	Since there's no "Slightly doubtful about" topic in this meeting, I'll put this here: Thanks to @mohit_aghera for dragging me along to present a keynote on BugSmashing.(He also made it very clear I had to put the sentence: "At no point a gun against my head was involved in this process" in... :innocent:)

2️⃣.3️⃣ Blockers - what’s getting in the way of your issues / goals

quietone	The winter solstice.
Paulo Henrique Cota Starling	I must say that sometimes the complexity of Drupal Core is a block for me. Of course I learned a lot since I started contributing, specially with Bugsmash Initiative which is as awesome place to learn...The point is to don't give up!

3️⃣ Core bug statistics - current state of open bugs

quietone

Last two weeks:

Today: 2021-06-22
From: 2021-06-08 to 2021-06-22
  All bugs  Open: 73, including 30 fixed
  Closed: 59
    Age   Count
     00   25
     01   09
     02   07
     03   02
     04   04
     05   04
     06   03
     07   02
     08   02
     14   01
           Status            Count
  closed (duplicate)           15
  closed (won't fix)            2
  closed (works as designed)    5
  closed (cannot reproduce)    18
  closed (fixed)               15
  closed (outdated)             4

  Approximately 199 yr reduction in total number of years of all open bugs.

  Only bugs tagged Bug Smash Initiative  
Open: 20, including 16 fixed  Closed: 37
    Age   Count
     00   12
     01   05
     02   03
     03   02
     04   04
     05   04
     06   02
     07   02
     08   02
     14   01

           Status            Count
  closed (duplicate)            6
  closed (works as designed)    2
  closed (fixed)                9
  closed (cannot reproduce)    17
  closed (outdated)             3

  Approximately 167 yr reduction in total number of years of all open bugs.

Griffyn Heels Love these stats, including the years reduction!

jibran FWIW, closed (fixed) are two week delayed.

4️⃣ Nominate your pet issue for a bug-smash target for the next fortnight

mohit_aghera

#2919927: Changing the indexes of field storage with non revision entity is broken

5️⃣ Help me - Is there anything you could use a :hand:

Spokje	Scoping an issue: I have "adopted" quite a lot of Coding Standard issues, which can become quite big, if all changes are done at once.I've got the feeling sometimes these issues can be lingering in RTBC for quite a while because of the sheer size of changes that have to be checked by a Core Committer, even thought the changes themselves are small.Is there a Rule-of-Thumb were we say: "Stop it! This is getting silly!" on patch size/number of changes? (edited)
lendude	Yeah these are hard to land, I think they usually land at Beta time, not sure. But at a time when nothing much else lands so the disruption is minimal.But no, there is no size limit in my experience. And since they tend to be automatically generated, it’s mostly about reviewing the method of generating them and then trusting the new rule that gets implemented to make sure the result is correct.
lendude	So its usually about getting them ready enough and then rolling a version at a specified, pre-arranged moment with committers that can be committedConstantly rerolling these is undoable
Matroskeen	Looking for review, and probably some help for this very annoying issue: #3197324: Exception trace cannot be serialized because of closure

6️⃣ @larowlan "9.2 testing. Anyone had an issues updating?"

larowlan	Other than rerolling patches been clean sailing for my projects
larowlan	Took one project from 8.9.16 to 9.2.0 :muscle:
kimb0	Wasn't there an issue with exiting in a hook for a contrib module? login_redirect something something
larowlan	redirect_after_login
larowlan	#3214949: Headers have already been sent after upgrade to Drupal 9.2 (can't login) its in the release notes too now under known issues
Spokje	Thanks for the patch on redirect_after_login @larowlan

7️⃣ @kimb0 "PHP8 compatibility for contrib"

kimb0	There are lot of projects that specify php: ^7.3 etc in composer.json, which prevents them being installed on php 8.
larowlan	https://drupal.slack.com/archives/C014CT1CN1M/p1624299173162900?thread_t...
kimb0	So not technically a bug?
larowlan	I think in there Ryan is talking about trickery with containers
Spokje	Will there be another round of PHPStan suggested patches for this? (Or maybe even is PHPStan already handling this?)
larowlan	PHP8 already emits deprecations for stuff that is going to go away
larowlan	e.g. using implode() with args in the wrong order
larowlan	but I don't know if there are rector rules or static analysis things

8️⃣ @quietone "Approval to add the new initiative page to the menu" (edited)

quietone	Is this page OK? Anything to change? https://www.drupal.org/node/3215948
quietone	@larowlan thanks for fixing the display of the table.
larowlan	griff did it first, but we worked out it was being filtered #3219990: Support colspan attribute on th elements
quietone	@Griffyn Heels Thanks to you for fixing the display of the table
Griffyn Heels	Sorry it took so long!

9️⃣ @quietone "What changes have you noticed in the Bug Reports?"

Griffyn Heels	https://www.drupal.org/project/issues/search/drupal?project_issue_follow...…]1&version%5B%5D=any_9.&version%5B%5D=any_8.&issue_tags_op=%3D
quietone	I have noticed that it is harder to find issues that need manual testing and then can be closed as outdated.
larowlan	i've found that we're getting better bug reports since we instigated templates, new reports seem to be better
larowlan	i've also found @cilefen is often the first person to reply to most issues

🔟 @larowlan "what constitutes attendance at meetings in terms of qualifying for issue credits?"

Griffyn Heels	As in, does just putting your name in attendance count?
larowlan	I think we should set a minimum level of participation
larowlan	I feel that showing up in the 'who's here' thread doesn't really constitute participation, thoughts?
quietone	This may help, #3215954: Easy Out of the Box - May 31 Meeting in Slack#comment-14124594
Griffyn Heels	How could you enforce it without creating lots of overhead for the people assigning credits?
larowlan	+1 to that list @quietone
larowlan	for reference in the minutes, EOTB consider active participation as:
larowlan	`Active participation can include: Making comments with useful information in threads Letting folks know what issues you are helping with and making a comment on issues Sharing issues and statuses Providing next steps for contributors`
quietone	I agree with @larowlan above. It is the responsibility of the person doing the minutes, and then it get approved at the next meeting.
larowlan	given that of late this has been mostly you @quietone , are you ok with that overhead?
larowlan	is that something we can share around more?
quietone	Sure. It can be tedious.
larowlan	are you still using mike's chrome plugin?
larowlan	who else is interested in helping with that? griff?
Griffyn Heels	I'm happy to help out with it
Griffyn Heels	If I'm not running the meeting I can do meeting notes/attribute credits?
larowlan	@Griffyn Heels there's a chrome extension that does a lot of the heavy lifting https://github.com/mdlutz24/drupal-meeting-parser
jibran	I have some counter points: We want more folks involved. We want to encourage them to participate. We want folks to read the minutes and then contribute. We want them to be part of the initiative. They are not getting involved because they are shy/ have language barrier, etc. On the other hand if you are rigging the system you are only getting 26 credits per year but you are getting emails about the d.o. minutes issue and you are paying attention to slack. It is something which is better than nothing.
larowlan	26 credits per year is a lot for just saying hi once a fortnight
Spokje	Initially I would go #TeamLarowlan here, but after reading through #TeamJibran points, it is a lot of effort for 26 cred/year. In an ideal world Larowlan ~~would be king~~ should be right, but since the world isn't ideal (at least until BugSmash has smashed all bugs) it seems to be a lot of overhead doing the monitoring and might (big stress on might) even put people of on trying out participating. Side note: Easier way of getting credits is putting up a screenshot of a screenshot that proves a patch was applied without errors and an upwards pointing thumb. Together with a friendly note: "I can confirm your screenshot of a cleanly applied patch is downloadable!", also a "RTBC +1" (of course) without a status change on the issue and see the d.o. credits stack up... (I will be doing this one day BTW) (edited)
larowlan	so perhaps we accept jibran's idea but we limit it. e.g. if you've come to 3 meetings and only said hi, we're doing something wrong, because we want you to get more invovled
lendude	Yeah I saw some users with more core credits than me this year, but they were all just meeting credits :shrug: (edited)
lendude	Something that we don’t control but might be an idea for d.o.Would it be possible to split these credits off (the ones that are in the ‘meetings’ component) and make the report on your user page report something like ‘code credits’ and ‘participation credits’?
lendude	Both are valuable, so not sure if this is something we really want to do, just spit balling
Spokje	Me like, but I think d.o. is actually pushing the view that not only code-stuff matters when contributing.
lendude	Yeah certainly not convinced that splitting is good, but it does feel like gaming the system is a little too easy this way, and that we could come up with a system for our meetings, but it might be better to come up with a system that works for all meetings
lendude	So @Gábor Hojtsy (he/him) maybe something that should (or maybe has?) come up in the cross initiative meetings?
larowlan	Yes I think it should be something that is adopted across the board - e.g EOOTB has their list, but it should be adopted universally
Gábor Hojtsy (he/him)	I use Mike's script in a way that does not give credit for the saying hi part (the intro thread). The original script from Sally also did that. I think we can formalize that into the script but it would require all meetings using it to use 0️⃣ or 1️⃣ for the intros.
Gábor Hojtsy (he/him)	The Drupal 10 meeting has 30% of participants roughly who always just say hi.
Gábor Hojtsy (he/him)	I think some of them expect they get credit for it.
Gábor Hojtsy (he/him)	But they don't.
Gábor Hojtsy (he/him)	I don't have a more elaborate tracking system that would be too much work.
Gábor Hojtsy (he/him)	One if the credit hunters at one point maybe figured this out and started to ask some good questions in the meeting. #win-win
lendude	Maybe update the start of the meeting text with ‘credit will be given to those participating outside the initial “who is here” threads’? I don’t know….
lendude	But I totally agree with @larowlan it would be great if it is something that is done consistently across all meetings/initiatives
Gábor Hojtsy (he/him)	@lendude if we make that too explicit, I am afraid, we could get more inline postings for the sake of getting credit, so not sure that improves the situation

:bell: Thanks bugsmashers, the meeting is over. Please keep chatting in the threads.

larowlan	thanks for running things Griffyn
jibran	Yeah, THANKS! Griff :smile: :wink:

Participants:

Indrajith KB, quietone, larowlan, kim.pepper, Griffyn Heels, mohit_aghera, gaurav mahlawat, jibran, Neslee, Spokje, lendude, Kunal Kapoor, anjalivijay, Matroskeen, mansoor20, hansa11, Guilherme Vitoriano Pereira, Paulo Henrique Cota Starling, Gábor Hojtsy

Comments

Comment #1

9 June 2021 at 12:11

quietone created an issue. See original summary.

Comment #2

quietone commented 9 June 2021 at 12:14

Parent issue:

#3215940: Meeting of the Bug Smash Initiative 2021-06-08

» #3153713: Bug Smash Initiative meetings - next: 2025-12-09

Comment #3

quietone commented 12 June 2021 at 02:18

Proposal to add an explanation in the IS that the meeting is open for 24 hours, comments made after that may not be included in the minutes posted here. And that discussions may continue in the threads and not appear here.