Problem/Motivation

Class discovery got lost looking for HttpClientInterface because the file name doesn't match the class name exactly.

Steps to reproduce

vendor/bin/drupal-check web/modules/contrib/backup_migrate/src/Core/Service/PhpCurlHttpClient.php

Proposed resolution

Rename HTTPClientInterface.php to HttpClientInterface.php

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
backup_migrate-rename-HTTPClientInterface.patch223 bytesjacob.embree

Comments

jacob.embree created an issue. See original summary.

larisse’s picture

larisse commented
Status: Needs review » Reviewed & tested by the community

I've been work in this module for a some time and never find any problem because this. But I know that is a good programming practice make this change, so I think this make sense. Thank you.

The patch applied correctly, so I'm change for RTBC.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3143649: Plan for Backup and Migrate 5.0.0

Whoops. Yes, this is a good idea.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Needed to do some weird hoopla because I run macOS locally with a case-insensitive file system, but I was able to commit it. Thank you both.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.