Problem/Motivation

It should be added type hints returns to setUp() methods in tets.
See: https://www.drupal.org/node/3114724

Steps to reproduce

Run the tests and see the deprecated notes

CommentFileSizeAuthor
#4 after.png138.36 KBlarisse
#2 3216285-2.patch1.51 KBpaulocs

Comments

paulocs created an issue. See original summary.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Assigned: paulocs » Unassigned
Status: Active » Needs review
StatusFileSize
new 3216285-2.patch1.51 KB
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Title: PHPUnit 8 introduced void return types on the following methods » PHPUnit 8 introduced void return types on setUp() methods
larisse’s picture

larisse commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after.png138.36 KB

I run the tests and the depreciations messages was removed.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

Thanks Larisse!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The change looks good, thank you. That said, I'm going to leave this a while because I don't want to break tests on 8.x just yet.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

But this doesn't break tests in 8.x, does it?
Test triggered in #2 is in Drupal 8.9...

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I had noticed that the change notice said "Introduced in branch: 9.0.x" so made an assumption..

  • DamienMcKenna committed e26bb52 on 5.0.x authored by paulocs 
    Issue #3216285 by paulocs, larisse, DamienMcKenna: PHPUnit 8 introduced...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed
Parent issue: » #3143649: Plan for Backup and Migrate 5.0.0

Committed. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.