Closed (fixed)
Project:
Drupal core
Version:
9.2.x-dev
Component:
base system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 May 2021 at 21:57 UTC
Updated:
10 Jun 2021 at 08:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
larowlanComment #3
larowlanComment #5
spokjeThis is all a bit messy (I know, SA-pressure...), but as far as I can tell:
- This issue is a follow-up from: #3215916: Update ckeditor to 4.16.1, where CKEditor was bumped to
4.17- That happened for 9.2.x and 9.3.x, but not for
9.1.x.The latter being the reason the patch won't apply to
9.1.x, since CKEditor4.16.1is already/still in there after SA-CORE-2021-003.- The test-fail on
9.3.xseemed like a random one, ordered retest. As soon as that comes back green, I'm going toRTBCComment #6
spokjeRemoved 9.1.x from IS
Comment #7
spokjeI stand corrected
9.1.9was shipped with CKEditor4.17(See https://git.drupalcode.org/project/drupal/-/blob/9.1.9/core/assets/vendo...), so9.1.xshould be patched.By now, I'm confused about why we're going backwards in CKEditor versions, leaving dev-branches using older stuff than actual releases, so I'll re-add
9.1.xto the IS and leave this issue alone.Comment #8
spokjeAt least it seemed I was right about something, the
9.3.xfail has been previously logged as random: #3203712: [random test failure] EntityDisplayTest::testExtraFields()Comment #9
effulgentsia commentedThe SA intended to update to 4.16.1, but unintentionally pulled in additional commits ahead of that tag. 4.17.0 has not yet been released, so going to 4.16.1 is in order to get onto a tagged release.
Comment #10
spokjeThanks @effulgentsia for clearing that up. :)
I've build the Drupal version of CKEditor 4.16.1 locally according to the instructions in
core/assets/vendor/ckeditor/build-config.jsand got the same result as3215929.patch, except for the expected cache-buster query string.So patch
3215929.patchis RTBC for me on9.3.xand9.2.x.To prevent
9.1.xholding up those branches, I've opened follow-up #3215970: [9.1.x] Fix CKEditor versions for that branchComment #11
spokjeComment #14
catchCommitted/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!
Comment #15
spokje