Problem/Motivation

Follow-up/Backport for #3215929: Fix CKEditor versions
9.2.x and 9.3.x and 9.1.x contain CKEditor 4.17.0 code but should be 4.16.1

Both 9.2.x and 9.3.x are handled in #3215929: Fix CKEditor versions, this issue is specifically for 9.1.x

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3215970

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !723

spokje’s picture

spokje
Primary language Dutch
commented

9.1.x never made the jump to CKEditor 4.16.0 #3211599: Update CKEditor to version 4.16.0, so all the "until years" in the copyright headers we're still on 2020. That's the reason the patch in #3215929: Fix CKEditor versions wouldn't apply.

MR in this issue should do the trick.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
spokje’s picture

spokje
Primary language Dutch
commented

Also checked that 8.9.x and 9.0.x already contain the actual CKEditor 4.16.1, so don't need any patching.

spokje’s picture

spokje
Primary language Dutch
commented
Issue tags: +Bug Smash Initiative
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

This looks good - double checked that CHANGES.md is as it should be (twice).

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I've confirmed that the main difference between this and 9.0.x and 9.2.x is the timestamp ckeditor sets on the build. And therefore this looks good.

Committed 2268ef1374 and pushed to HEAD. Thanks!

  • alexpott committed 2268ef1 on 9.1.x 
    Issue #3215970 by Spokje: [9.1.x] Fix CKEditor versions

Spokje closed merge request !723

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.