Closed (fixed)
Project:
Rocketship theme generator
Version:
2.0.4
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 May 2021 at 17:31 UTC
Updated:
8 Jun 2021 at 15:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gaborm commentedComment #3
vm commentedBetter title
Comment #4
vm commentedcorrect title paste.
Comment #5
vm commentedmore descriptive.
Comment #7
rembrandx commented@gaborm: could you check out the change I committed? This should fix your issues. One was a variable that was named incorrectly, another was I forgot to do a check for undefined:
https://www.drupal.org/commitlog/commit/104686/be8b8ea910aa1e4e496b81278...
If this fixes it, I'll add a new tag.
@VM thanks for tweaking the issue!
Comment #9
rembrandx commentedThe weird thing is, I don't get the error on my work computer, nor during tests in Git pipelines but I do see it on my home computer. I'm thinking it has to do with the version of PHP that it's running + what kind of error logging is turned on by default.
In any case, I hope the tweak I committed fixes it for you.
Comment #10
rembrandx commentedI got the issues that were mentioned, fixed on my home computer, so I think we're good.
Feel free to reopen if you're still having PHP errors.
Also, if you could mention what php version you are running this in, that would be helpful to further debug this.
Comment #11
gaborm commentedSame problem (but no PHP notice):
After enable theme (dxf2) the site crash. In dblog:
PHP: php-7.4.19-1.fc34.x86_64
rocketship_theme_generator: 2.0.4 released 25 May 2021
Comment #12
rembrandx commentedOkay, so there's 2 separate issues:
- PHP errors
-Some (or possibly a lot of) twig templates not being found
The first issue is fixed in 2.0.3.
The other one is something I can't reproduce, so it's most likely one of these 2 things:
1)
You're using components 3.x, which is currently untested in the current Rocketship distributions (uses 2.x). The way the aliases are constructed in dxf2.info is not compatible. It's easily fixed by rewriting it like this:
2) Or the templates mentioned, were not copied by the generator. I tested in php 5.6, 7.3 and 7.4 and it copies + the theme works on my end. If the templates don't copy for you, it's a mystery to me. As a quick-fix, you could try manually copying the missing templates from the 'templates/BASE'-folder in the generator and replacing mentions of
%theme_prefix%with your theme's machine name:dxf2Comment #13
rembrandx commentedComment #14
gaborm commentedI uploaded the (original) generated demo theme. Can You examine it?
Comment #15
rembrandx commentedIt has the correct twig-templates for the user pages and everything renders just fine in my test project.
The problem is mostly likely that you are missing a dependency.
As I mentioned, you need the correct version of this components module to be enabled. 8.x-2.4 (the latest green one) should be compatible with the theme.
Also make sure you have this Unified Twig Extensions module installed and enabled.
Both of these modules are normally installed by the Rocketship Core module (part of the the Rocketship distribution). So if you don't have those 2 modules enabled, the root cause might be something failed during the Rocketship installation or something that was changed to your project's composer file and you'll probably have more issues then just the theme not loading. If that is the case, you're better off making an issue in the Rocketship distribution project.
Comment #16
gaborm commentedThanks! It works! :)
(components + unified_twig_ext modules)
Comment #17
rembrandx commented