Problem/Motivation

When checking a page, with an AJAX webform, with Lighthouse, this will result in the following notice:

Links are not crawlable

Search engines may use href attributes on links to crawl websites. Ensure that the href attribute of anchor elements links to an appropriate destination, so more pages of the site can be discovered. Learn More

This error is because the element is an a-tag without a required href attribute.

Proposed resolution

Replace the a-tag with a span

Issue fork webform-3214340

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

JeroenT created an issue. See original summary.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Issue summary: View changes

A similar issue: in core #2784311: "Skip to main content" should link to main tag or similar

JeroenT opened merge request !29

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Active » Needs review
jrockowitz’s picture

jrockowitz commented
Version: 6.x-dev » 8.x-5.x-dev

Thank you for the patch.

Maybe we should also remove the tabindex="-1" aria-hidden="true" from the tag.

Also, this issue should be addressed in 8.x-5.x. We might have to switch to using patches.

JeroenT opened merge request !30

JeroenT closed merge request !29

  • jrockowitz committed a6d4ed0 on 8.x-5.x authored by JeroenT 
    Issue #3214340 by JeroenT: Links are not crawable error in Lighthouse
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

  • jrockowitz committed a6d4ed0 on 6.x authored by JeroenT 
    Issue #3214340 by JeroenT: Links are not crawable error in Lighthouse

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.