Media switcher output doesn't work with i18n

Thank you.

I don't have a multilingual setup currently, but let's track it down for anyone who are feeling invited to provided patches.

Is it Blazy Filter as I cannot find any of its usages in Blazy Filter, and won't makes sense in Filter either:
https://git.drupalcode.org/project/blazy/-/blob/8.x-2.2/src/Plugin/Filte...

$ grep -r "content_url" ./src
./src/Dejavu/BlazyStylePluginTrait.php:          $settings['content_url'] = isset($image['rendered']['#url']) ? $image['rendered']['#url'] : '';
./src/Dejavu/BlazyStylePluginTrait.php:          if (empty($settings['media_switch']) && !empty($settings['content_url'])) {
./src/BlazyFormatter.php:    $settings['content_url']    = $settings['absolute_path'] = $absolute_path;
./src/BlazyManager.php:      if ($settings['media_switch'] == 'content' && !empty($settings['content_url'])) {
./src/BlazyManager.php:        $element['#url'] = $settings['content_url'];
./src/BlazyDefault.php:      'content_url'    => '',

> - Create a view page with the media image using blazy formatter
The usage is here:
https://git.drupalcode.org/project/blazy/-/blob/8.x-2.2/src/BlazyManager...

if ($settings['media_switch'] == 'content' && !empty($settings['content_url'])) {
  $element['#url'] = $settings['content_url'];
}

Since content_url comes from anywhere, we cannot do correction in the above lines.
A few candidates:

• Views with image URL, appears similar to yours:
  https://git.drupalcode.org/project/blazy/-/blob/8.x-2.x/src/Dejavu/Blazy...
• All blazy-related field formatters with entities:
  https://git.drupalcode.org/project/blazy/-/blob/8.x-2.x/src/BlazyFormatt... which leads here: https://git.drupalcode.org/project/blazy/-/blob/8.x-2.x/src/BlazyFormatt...

  // Deals with UndefinedLinkTemplateException such as paragraphs type.
      // @see #2596385, or fetch the host entity.
      if (!$entity->isNew() && method_exists($entity, 'hasLinkTemplate')) {
        if ($entity->hasLinkTemplate('canonical')) {
          $url = $entity->toUrl();
          $internal_path = $url->getInternalPath();
          $absolute_path = $url->setAbsolute()->toString();
        }
      }

If it were a field within entities, such as Link as seen at any blazy-related Media/ Paragraphs, etc. formatters, we do have solution here:
https://git.drupalcode.org/project/blazy/-/blob/8.x-2.2/src/BlazyEntity....

Unfortunately your use case appears to fall into Views with image URL as identified above.
And indeed, I haven't been able to make it more language aware without proper setup.

Patches are welcome. Thanks.

UPDATED:
Deleted irrelevant lines to your use case since you said blazy formatter, not image formatter.
But because your use case is not Media/ Paragraphs entity formatters, alike, hence node, so the second applied.

Thank you.

Just minor nits:
We should avoid calling non-di like \Drupal:: at non-static classes.

But I need your help to verify if still working or not, basically replacing \Drupal::languageManager()->getCurrentLanguage()->getId(); with $items->getLangcode();:
https://git.drupalcode.org/project/drupal/-/blob/9.0.13/core/lib/Drupal/...
https://git.drupalcode.org/project/drupal/-/blob/8.9.15/core/lib/Drupal/...

Then the previous mentioned sample might apply with minor adjustments:
https://git.drupalcode.org/project/blazy/-/blob/8.x-2.x/src/BlazyEntity....

Perhaps something like:

-        $url = $entity->toUrl();
+
+        // Check if multilingual is enabled (@see #3214002)
+        $language_code = $items->getLangcode();
+        if ($entity->hasTranslation($language_code)) {
+          // Load the translated url.
+          $url = $entity->getTranslation($language_code)->toUrl();
+        }
+        else {
+          // Otherwise keep the standard url.
+          $url = $entity->toUrl();
+        }
+

Other minor nits are no big-deal:
https://www.drupal.org/pift-ci-job/2065050

Please focus on verifying whether the above replacement work or not instead.
Feel free to update your patch if working. If not, we might need to figure out another alternative.

Thanks again.

Bad suggestions, then :)

The last, ugly, resort is moving that \Drupal::languageManager() into static method such as here:
https://git.drupalcode.org/project/blazy/-/blob/8.x-2.x/src/Blazy.php#L489

Please update your patch by adding this method into Blazy.php:

/**
   * Returns a wrapper to pass tests, or DI where adding params is troublesome.
   */
  public static function languageManager() {
    return \Drupal::languageManager();
  }

Then replace \Drupal::languageManager() in your patch by Blazy::languageManager()

This should do till we have proper DI, perhaps at Blazy 3+.

We need to have a more permanent solution as it appears we have other similar warnings, not errors, of course:

FILE: .../drupal/drupal9/loc/web/modules/custom/blazy/src/Dejavu/BlazyVideoBase.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 70 | WARNING | \Drupal calls should be avoided in classes, use dependency
    |         | injection instead
--------------------------------------------------------------------------------


FILE: ...ules/custom/blazy/src/Plugin/Field/FieldFormatter/BlazyOEmbedFormatter.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 80 | WARNING | \Drupal calls should be avoided in classes, use dependency
    |         | injection instead
--------------------------------------------------------------------------------

#6 is just temporary.
Perhaps adding it in as service tags will be less temporary, although still temporary till the next branch works.

Attached to add the language manager service and also to address the other similar issue once.

Fixed minor CS.

Be sure to run the update, or clear cache in the least as we are adding a service.

Committed. Thank you for contribution.

Sadly, I just ran into an issue with this fix:

The website encountered an unexpected error. Please try again later.

InvalidArgumentException: Invalid translation language (en) specified. in Drupal\Core\Entity\ContentEntityBase->getTranslation() (line 873 of core/lib/Drupal/Core/Entity/ContentEntityBase.php).

Drupal\blazy\BlazyFormatter->buildSettings() (Line: 25)

This part isn't enough as it seems. The site is multilingual but that doesn't mean the selected translation exists:

// Check if multilingual is enabled (@see #3214002).
        if ($this->languageManager->isMultilingual()) {
          // Load the translated url.
          $url = $entity->getTranslation($settings['current_language'])->toUrl();
        }

We further need a

$entity->hasTranslation($settings['current_language'])

check:

// Deals with UndefinedLinkTemplateException such as paragraphs type.
    // @see #2596385, or fetch the host entity.
    if (!$entity->isNew() && method_exists($entity, 'hasLinkTemplate')) {
      if ($entity->hasLinkTemplate('canonical')) {

        // Check if multilingual is enabled (@see #3214002).
        if ($this->languageManager->isMultilingual() && $entity->hasTranslation($settings['current_language'])) {
          // Load the translated url.
          $url = $entity->getTranslation($settings['current_language'])->toUrl();
        }
        else {
          // Otherwise keep the standard url.
          $url = $entity->toUrl();
        }

        $internal_path = $url->getInternalPath();
        $absolute_path = $url->setAbsolute()->toString();
      }
    }

Tested and works! I'll create a merge request.

MR created. Would ne nice to have a new stable release containing this fix.

Too late to the party but ok 😂

Can we remove $this->languageManager->isMultilingual() && as said in #4?

Well yes I guess we could. On the other hand the $this->languageManager->isMultilingual() is very fast, so the combination is smart as only the first condition is evaluated on non-multilang projects. You decide :)

Logically the first condition is not needed.

Yes, please. Nobody complained at two other places with just that so far.

Updated!

I had delayed 2 weeks for 2.3 from the initial plan to accommodate these kinds of misses.
I released 2.3 before this weekend to test the waters, normally full releases got attentions better than DEV.

We'll release another hot fix by weekend before weekend warriors attack. And also to re-check other potential misses, if any.

Committed. Thank you for contribution.

Thanks @Anybody, switching from 2.3.0 to the current dev fixes the error i was encountering after the update to 2.3.0

InvalidArgumentException: Invalid translation language (de) specified. in Drupal\Core\Entity\ContentEntityBase->getTranslation() (Zeile 873 in /docroot/core/lib/Drupal/Core/Entity/ContentEntityBase.php).

Encountered the same error as #20. Switching to current dev fixed it for me.