Olivero: Double focus on li items in safari.
This issue is only reproducible in safari.

Can be seen on live preview: https://tugboat-aqrmztryfqsezpvnghut1cszck2wwasr.tugboat.qa/tabs/restric...

Steps to reproduce:
1. focus on li(tabs__tab)
2. Focus on the tab in it (tabs__link).

Now the double focus will appear.

Adding screenshot for reference.

CommentFileSizeAuthor
#4 3213994-4.patch817 bytesgauravvvv
#3 3213994-after.png14.16 KBcindytwilliams
#3 3213994-before.png13.99 KBcindytwilliams
#2 3213994-2.patch812 bytesgauravvvv
Screenshot 2021-05-14 at 16.08.43.png105.9 KBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3213994-2.patch812 bytes

I have attached a patch, Please verify if it is working or not.

cindytwilliams’s picture

cindytwilliams commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3213994-before.png13.99 KB
new 3213994-after.png14.16 KB

Patch #2 applied cleanly, and fixed the double-focus on li items issue in Safari.

Before patch (double focus outline):

After patch:

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3213994-4.patch817 bytes

Re-rolled patch #2.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 3213994-4.patch, failed testing. View results

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Reviewed & tested by the community

Unrelated failure, Moving back to RTBC

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Reviewed & tested by the community » Closed (won't fix)

I know this is only a minor change, but I'm okay with the double outline in Safari. To get the focus styles on links within Safari is a bit of a process (hold down the option key, or change some default settings), and if people are doing that, it's nice to have some very prominent focus states.

Thanks for the issue report and work, though.