Umami demo: input fields overflow on quick edit.

Adding screen recording for reproducing the issue.

CommentFileSizeAuthor
#7 Screenshot 2022-07-01 at 1.15.56 PM.png245.02 KBrinku jacob 13
#4 input_field_overflow_issue-3213959-04.patch838 byteslokeshsahu
#3 after-patch.png48.58 KBlokeshsahu
#3 input_field_overflow_issue-3213959-03.patch839 byteslokeshsahu
Screen Recording 2021-05-14 at 10.57.50.mov5.63 MBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

lokeshsahu’s picture

lokeshsahu commented
Assigned: Unassigned » lokeshsahu
lokeshsahu’s picture

lokeshsahu commented
Assigned: lokeshsahu » Unassigned
Status: Active » Needs review
StatusFileSize
new input_field_overflow_issue-3213959-03.patch839 bytes
new after-patch.png48.58 KB

I have created a patch for the above issue, please let me know if it is working.
I have added a screenshot for better reference.

lokeshsahu’s picture

lokeshsahu commented
StatusFileSize
new input_field_overflow_issue-3213959-04.patch838 bytes

I have updated the previous patch #3 and creating a new patch for the above issue, please let me know if it is working.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

rinku jacob 13’s picture

rinku jacob 13 commented
StatusFileSize
new Screenshot 2022-07-01 at 1.15.56 PM.png245.02 KB

Actually this issue was not in 9.5.x. But i can see one more issue. when we click quick edit on Ingredients,
that was overlapped in recipie instruction . That should be a bug.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Project: Drupal core » Quick Edit
Version: 10.1.x-dev » 1.0.x-dev
Component: Umami demo » Code

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 200, following Review a patch or merge require as a guide.

Thank you for the patch

With quickedit having been removed in D10 moving this to the contrib module

pingwin4eg’s picture

pingwin4eg
Location Zaporizhia 🇺🇦
commented
Status: Needs review » Needs work

The patch needs a re-roll against the contrib module.