Problem/Motivation

When I run some tests in Drupal 9^, I get the following deprecation notice:
$modules property must be declared protected
See: https://www.drupal.org/node/2909426

Steps to reproduce

Run the webform/modules/webform_access/tests/src/Functional/WebformAccessSubmissionViewsTest.php and see the deprecation notice mentioned above.

Proposed resolution

Change the visibility properties of the variables to protected.

CommentFileSizeAuthor
#10 3213630-13.patch103.14 KBjrockowitz
#9 3213630-11.patch103.75 KBjrockowitz
#8 3213630-9.patch104.51 KBjrockowitz
#7 3213630-7.patch105.15 KBjrockowitz
#5 webform_tests_public.png15.22 KBguilhermevp
#3 3213630-3.patch100.88 KBpaulocs
#3 interdiff-2-3.txt1.22 KBpaulocs
#2 3213630-2.patch102.89 KBpaulocs

Issue fork webform-3213630

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

paulocs created an issue. See original summary.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Assigned: paulocs » Unassigned
Status: Active » Needs review
StatusFileSize
new 3213630-2.patch102.89 KB

First try.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
StatusFileSize
new interdiff-2-3.txt1.22 KB
new 3213630-3.patch100.88 KB

WebformGroupBrowserTestBase, WebformGroupUserInterfaceTest and WebformGroupSubmissionAccessTest could not be addressed because GroupBrowserTestBase of the group module still have public static $modules.

jrockowitz’s picture

jrockowitz commented
Title: $modules property in tests must be declared protected » [Drupal 9.x] $modules property in tests must be declared protected
guilhermevp’s picture

guilhermevp commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new webform_tests_public.png15.22 KB

Patch address D9 standards accordingly within the possibilities. As stated, some public declarations remain.

jrockowitz’s picture

jrockowitz commented
Status: Reviewed & tested by the community » Postponed

I think this patch has to be postponed until Drupal 9.x is the only supported version. BTW, this is what I prefixed the title with [Drupal 9.x]

jrockowitz’s picture

jrockowitz commented
Status: Postponed » Needs review
StatusFileSize
new 3213630-7.patch105.15 KB
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3213630-9.patch104.51 KB
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3213630-11.patch103.75 KB
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3213630-13.patch103.14 KB
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

Will next webform release support drupal 9 only?

jrockowitz’s picture

jrockowitz commented

I think I am going to be nice to people still on Drupal 8 and not require Drupal 9.x until next year.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

so if this issue is committed, it will break the tests in Drupal 8, won't it?

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Postponed

Yep. We might want to create a [meta] ticket to support only Drupal 9.x and track all the issues that can be resolved when we only support D9.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Related issues: +#3249740: [META] Ensure webform compatibility with Drupal 9 only.
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Parent issue: » #3249740: [META] Ensure webform compatibility with Drupal 9 only.
Related issues: -#3249740: [META] Ensure webform compatibility with Drupal 9 only.
jrockowitz’s picture

jrockowitz commented
Status: Postponed » Needs work

We need to move the patch into a branch and create a merge request.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Reviewed & tested by the community

jrockowitz opened merge request !116

jrockowitz’s picture

jrockowitz commented
Version: 6.x-dev » 6.2.x-dev

  • jrockowitz committed 54463b5 on 6.2.x 
    Issue #3213630 by jrockowitz, paulocs, guilhermevp: [Drupal 9.x] $...
jrockowitz’s picture

jrockowitz commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.