Problem/Motivation

Looks like an older version of abraham/twitteroauth in module's composer.json is preventing the module to be compatible with PHP 7.4.

Proposed resolution

Update abraham/twitteroauth library to latest version.

User interface changes

NA

API changes

NA

Data model changes

NA

CommentFileSizeAuthor
#8 3213335-08.patch1.37 KBdevad
#7 3213335-07.patch967 bytesdevad
#3 php74-compatibility-3213335-3.patch731 bytesdivyesh19
#2 php74-compatibility-3213335-2.patch341 bytesdivyesh19

Comments

divyesh19 created an issue. See original summary.

divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new php74-compatibility-3213335-2.patch341 bytes
divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
StatusFileSize
new php74-compatibility-3213335-3.patch731 bytes

Updating the ludwig.json as well.

divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
meet_bhanvadia’s picture

meet_bhanvadia commented
Status: Needs review » Reviewed & tested by the community

Patch #3 looks good. It works well with PHP 7.4.
It would be great if merged to dev.

devad’s picture

devad commented

The ludwig.json file needs composer/ca-bundle library as well (the new dependency of abraham/twitteroauth 2.0.1).

Here is how the new ludwig.json file should look like:

{
    "require": {
        "abraham/twitteroauth": {
            "version" : "v2.0.1",
            "url": "https://github.com/abraham/twitteroauth/archive/2.0.1.zip"
        },
        "composer/ca-bundle": {
            "version" : "v1.2.9",
            "url": "https://github.com/composer/ca-bundle/archive/1.2.9.zip"
        }
    }
}
devad’s picture

devad commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3213335-07.patch967 bytes

Patch with proper ludwig.json file.

devad’s picture

devad commented
StatusFileSize
new 3213335-08.patch1.37 KB

I have git cloned the wrong branch previously. Here is a proper patch for 2.0.x branch.

Adding few extra spaces to composer.json file as well to follow the .json 4 spaces recommended indent policy.

devad’s picture

devad commented
divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

@devad, thanks for the updated patch. Works well.

  • baikho committed c17e7d8 on 2.x authored by devad 
    Issue #3213335 by divyesh19, devad, meet_bhanvadia: Compatibility with...
baikho’s picture

baikho commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.