Remove <u> tag from filter module since it has been deprecated.

CommentFileSizeAuthor
#6 after-patch.png689.46 KBradheymkumar
#4 After-applying-patch.png563.33 KBMadhu kumar
#4 Applying-patch.png35.81 KBMadhu kumar
#3 3213173-applied_patch.png9.83 KBabhijith s
#2 3213173-2.patch932 bytesguilhermevp

Comments

Gauravmahlawat created an issue. See original summary.

guilhermevp’s picture

guilhermevp commented
Status: Active » Needs review
StatusFileSize
new 3213173-2.patch932 bytes

Sending patch. Please review.

abhijith s’s picture

abhijith s commented
StatusFileSize
new 3213173-applied_patch.png9.83 KB

Applied patch #2 on 9.3.x and it removes tag from filter module.

after

Madhu kumar’s picture

Madhu kumar commented
StatusFileSize
new Applying-patch.png35.81 KB
new After-applying-patch.png563.33 KB

Applied patch #2 cleanly and working as expected.Sharing screenshot for the referene.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

@Abhijith S, @Madhu kumar: there is no need to check if patches apply or upload screenshots of patches being applied, the automated test bot will report back if the patch doesn't apply.

radheymkumar’s picture

radheymkumar commented
StatusFileSize
new after-patch.png689.46 KB

This patch is applied correctly.
Thanks

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

@radheymkumar: As I said in #5, there is no need to show screenshots of patches being applied - the bot will check this for us.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

not clear why this tag is deprecated and how it will work for existing sites

daffie’s picture

daffie commented

I am missing the link to the decision that the tag < u > is deprecated. Maybe also add a test that the method no longer returns what you are removing.

rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented

According to the MDN Web Docs the u element got deprecated in HTML4. But in HTML 5 it got a new semantic meaning - to mark text as having some form of non-textual annotation applied. Instead of removing the u element from the filter module why not mind the new semantic meaning instead by relabeling/renaming it? The listed new use cases on MDN web docs are mostly annotations related (e.g. indicating spelling errors)

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

Preemptively removing credit for patch-applying screenshots.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Agree with #10, to me this is won't fix as HTML5 repurposes <u> in the spec - it is not deprecated that I can see.

andypost’s picture

andypost
he/him
Primary language Russian
commented

+1 to better docs

vikashsoni’s picture

vikashsoni commented

@ guilhermevp patch applied successfully
Thanks for the patch

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.