Create PHPUnit browser test coverage for media type creation.

Issue fork media_entity_link-3212822

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dishabhadra created an issue. See original summary.

dishabhadra’s picture

dishabhadra commented
Assigned: Unassigned » dishabhadra
dishabhadra’s picture

dishabhadra commented
Status: Active » Postponed
dishabhadra’s picture

dishabhadra commented
Assigned: dishabhadra » Unassigned
d.fisher’s picture

d.fisher commented
Version: 1.0.0 » 2.0.x-dev
Category: Plan » Task
Status: Postponed » Active
d.fisher’s picture

d.fisher commented

darren.fisher opened merge request !6

d.fisher’s picture

d.fisher commented
Status: Active » Needs work

Not getting anywhere with this one. Tests are not my strong point so setting to Needs Work! Anyone who has a deeper knowledge, feel free to duck in!

daniel.j made their first commit to this issue’s fork.

d.fisher’s picture

d.fisher commented

Looking good. There is a phpcs error still though.

85 | WARNING | Unused variable $media. (DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable)
135 | WARNING | Unused variable $media. (DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable)

danrod made their first commit to this issue’s fork.

danrod’s picture

danrod
Location Ottawa
commented

Looks like not even the composer tests are passing, I'll look into that, sorry for the inconvenience !

daniel.j’s picture

daniel.j commented

Appologies, I meant to follow up with a comment after pushing changes but got cought up with something else.

The tests added are for the form, I hope to follow up with some tests for the media plugin itself. I'll be happy to clean up the tests already pushed as well for cs and stan issues.

daniel.j’s picture

daniel.j commented
Related issues: +#3532187: Composer issue when dealerdirect/phpcodesniffer-composer-installer update from v1.0.0 to v1.1.0

CI all green. Please see https://www.drupal.org/project/drupal/issues/3532187 with regards to the composer issue.

daniel.j’s picture

daniel.j commented
Status: Needs work » Needs review

Changes added include Unit and Kernal tests for 'MediaEntityLink.php', also fixes for composer, phpcs, phpstan.

Please review the tests.

d.fisher’s picture

d.fisher commented
Status: Needs review » Reviewed & tested by the community

Looking good. Tests pass. Pipelines pass. This is awesome. Great work! @danrod are you happy for me to commit this?

danrod’s picture

danrod
Location Ottawa
commented

Hi @d.fisher I'm ok with this, please do commit !
Great work !

danrod’s picture

danrod
Location Ottawa
commented

@daniel.j , thanks a lot of the information. I was having the same issue with some projects and I'll apply that solution.

  • d.fisher committed b5fe8ebe on 2.0.x 
    Issue #3212822 by d.fisher, daniel.j, danrod, dishabhadra: Media type...
d.fisher’s picture

d.fisher commented
d.fisher’s picture

d.fisher commented
Status: Reviewed & tested by the community » Fixed

Thank you everyone for all your efforts. Great to finally get this one merged, released, and marked as fixed!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.