Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Olivero: repat placeholder CSS for IE11.
Steps to reproduce:
1. go to olivero/css/components/form.pcss.css file.
2. we have written IE11 specific css for placeholder. :-ms-input-placeholder {color: var(--color--gray-30) !important; }
which is not required. Because yarn compiles the ::placeholder to :-ms-input-placeholder
for IE11 support.
3. Adding screen-recording to better understanding.
Resolution:
::placeholder {
color: var(--color--gray-30);
}
/* IE 10 and 11 needs this set as important. */
:-ms-input-placeholder {
color: var(--color--gray-30) !important;
}
This code compiles to
:-ms-input-placeholder {
color: #7e96a7;
}
::placeholder {
color: #7e96a7;
}
/* IE 10 and 11 needs this set as important. */
:-ms-input-placeholder {
color: #7e96a7 !important;
}
So we can remove this extra line of code.
/* IE 10 and 11 needs this set as important. */
:-ms-input-placeholder {
color: var(--color--gray-30) !important;
}
Comment | File | Size | Author |
---|---|---|---|
#28 | 3212691-28.patch | 914 bytes | immaculatexavier |
| |||
#23 | remove placeholder CSS for IE11.patch | 898 bytes | sauravkashyap |
Comments
Comment #2
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for Drupal India Association commentedComment #3
mohitw CreditAttribution: mohitw commentedComment #4
mohitw CreditAttribution: mohitw commentedComment #5
mohitw CreditAttribution: mohitw commentedComment #6
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for Drupal India Association commentedI have removed the extra line of code and verified it on IE as well. Please review.
Comment #7
Sakthivel M CreditAttribution: Sakthivel M at QED42 for Drupal India Association commented#6 patch applied successfully. The patch is not working.
I have attached screenshot
Comment #8
Sakthivel M CreditAttribution: Sakthivel M at QED42 for Drupal India Association commented#8 Please review the patch
Comment #9
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for Drupal India Association commentedMy bad. Works as designed.
Comment #10
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for Drupal India Association commentedComment #11
chetanbharambe CreditAttribution: chetanbharambe at QED42 for Drupal India Association commentedVerified and tested patch #8.
Patch applied successfully and looks good to me.
Testing Steps:
# Goto: Home page
# Click on Search icon -> Press Enter key
# Go to search input field
# User is able to see repeated placeholder CSS on IE11 Browser
Expected Results:
# User should not see repeated placeholder CSS on IE11 Browser
Actual Results:
# Currently User is able to see repeated placeholder CSS on IE11 Browser
Can be a move to RTBC.
Comment #13
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for Drupal India Association commentedUnrelated failure.
Comment #14
lauriiiIs there a specific reason we can remove the !important?
Comment #15
mherchelComment #16
xjmComment #18
Gauravvvv CreditAttribution: Gauravvvv for Drupal India Association commentedComment #19
Gauravvvv CreditAttribution: Gauravvvv at Srijan | A Material+ Company for Drupal India Association commentedComment #21
longwaveWe can definitely drop this from 10.0.x as we no longer support IE11.
Comment #22
pooja saraah CreditAttribution: pooja saraah at Srijan | A Material+ Company for Drupal India Association commentedAttached reroll patch against 10.0.x
Comment #23
sauravkashyap CreditAttribution: sauravkashyap as a volunteer and at Srijan | A Material+ Company commentedi have removed the extra line code
Comment #24
smustgrave CreditAttribution: smustgrave at Mobomo commentedComment #25
smustgrave CreditAttribution: smustgrave at Mobomo commentedLooks like #23 passes current 9.5 tests if anyone with IE can test.
Comment #26
longwaveAs per https://caniuse.com/css-placeholder
:-ms-input-placeholder
was only used until Edge 18 which is no longer supported (and IE10/11, which is not listed on caniuse for some reason)Comment #27
catchDoesn't apply against 10.x
Comment #28
immaculatexavier CreditAttribution: immaculatexavier as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedRerolled patch against 10.0.x
Comment #29
smustgrave CreditAttribution: smustgrave at Mobomo commentedComment #30
longwaveComment #32
catchCommitted/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!