Olivero: my account focus color not matching with other items

Steps to reproduce:
1. go to the main navigation accounts menu.
2. Focus on my account and log out.
3. Working fine on the desktop screen.
4. Issue is below 1200px screen on mobile and tab devices. Added screenshot for reference.

CommentFileSizeAuthor
#31 3211562 before patch home.png8.04 KBaarti zikre
#31 3211562 before patch logout.png7.75 KBaarti zikre
#31 3211562 after patch logout.png7.85 KBaarti zikre
#31 3211562 before patch home.png98.45 KBaarti zikre
#31 3211562 before patch logout.png103.25 KBaarti zikre
#31 3211562 after patch logout.png110 KBaarti zikre
#30 interdiff_29-30.txt620 bytesranjith_kumar_k_u
#30 3211562-30.patch1.05 KBranjith_kumar_k_u
#29 account_focus_color_not_matching_with_other_items-3211562-29.patch1.1 KBrakhi soni
#26 After patch Log out.png14.13 KBAamir M
#26 Before patch Log out.png14.38 KBAamir M
#26 After patch My account.png14.47 KBAamir M
#26 Before patch My account.png14.74 KBAamir M
#26 Screenshot from 2022-07-27 12-51-29.png133.52 KBAamir M
#24 After-patch.png41.82 KBShubham Sharma 77
#24 Before-patch.png39.54 KBShubham Sharma 77
#21 After--patch--pic.png27.68 KBvikashsoni
#21 Before--patch--pic.png26.59 KBvikashsoni
#19 text-overflows-height.png37.38 KBbnjmnm
#17 Focus-working.png38.7 KBsagarchauhan
#14 After Patch 3211562 iPad.png328.06 KBchetanbharambe
#14 After Patch 3211562 iPhone1.png197.09 KBchetanbharambe
#14 After Patch 3211562 iPhone.png189.66 KBchetanbharambe
#14 Before Patch 3211562 Two.png196.2 KBchetanbharambe
#14 Before Patch 3211562 One.png180.11 KBchetanbharambe
#13 my_acc_after_patch.png3.92 KBguilhermevp
#13 focus_my_acc_log_out_before.png3.81 KBguilhermevp
#13 focus_home_before.png3.94 KBguilhermevp
#11 3211562.11.patch1.7 KBsakthivel m
#7 Screenshot 2021-04-30 at 11.35.58.png28.82 KBgauravvvv
#7 Screenshot 2021-04-30 at 11.33.48.png34.06 KBgauravvvv
#7 3211562-6.patch1.97 KBgauravvvv
#4 3211562-4.patch1.32 KBgauravvvv
#2 Screenshot 2021-04-30 at 11.00.48.png30.6 KBgauravvvv
#2 3211562-2.patch1.23 KBgauravvvv
Screenshot 2021-04-30 at 10.52.08.png42.96 KBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

StatusFileSize
new1.23 KB
new30.6 KB

I have provided the patch. please verify.

I have updated the focus color, added an after-patch screenshot for reference.

gauravvvv’s picture

Status: Active » Needs review
gauravvvv’s picture

StatusFileSize
new1.32 KB

Re-rolled patch #2.

gauravvvv’s picture

Issue summary: View changes
abhijith s’s picture

StatusFileSize
new7.87 KB
new8.06 KB

Applied patch #2 and it works My account and logout links.

Before patch:
before

After patch:
after

gauravvvv’s picture

StatusFileSize
new1.97 KB
new34.06 KB
new28.82 KB

I have attached a patch which cover's login link too. please review.

gauravvvv’s picture

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

sakthivel m’s picture

Status: Needs review » Needs work

#7 Patch failed

sakthivel m’s picture

Status: Needs work » Needs review
StatusFileSize
new1.7 KB

#11 please review the patch

chetanbharambe’s picture

Assigned: Unassigned » chetanbharambe
guilhermevp’s picture

StatusFileSize
new3.94 KB
new3.81 KB
new3.92 KB

Patch works as intended.

Tested in a Ipad screen (768x1024)

Home focus:
1

My account and Log Out Focus before:
2

My accout and Log Out focus after patch:
3

RTBC +1

chetanbharambe’s picture

Assigned: chetanbharambe » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new180.11 KB
new196.2 KB
new189.66 KB
new197.09 KB
new328.06 KB

Verified and tested patch #11.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto any Responsiveness devices (Mobile, iPad)
# Goto: Appearance -> Install Olivero theme.
# Go to Homepage -> Click on hamburger menu
# Press Tab key and check the focus color which is not matching for My account and a logout button.

Expected Results:
# Focus color for My account and a logout button should match with other items.

Actual Results:
# My account and logout focus color not matching with other items

Looks good to me.
Can be a move to RTBC.

catch’s picture

Category: Support request » Bug report

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 3211562.11.patch, failed testing. View results

sagarchauhan’s picture

StatusFileSize
new38.7 KB

Reran the test for #11. The previous test failing doesn't seem to be related to the patch. Reviewed the patch and found that it works correctly. RTBC + 1

sagarchauhan’s picture

Status: Needs work » Needs review
bnjmnm’s picture

Issue summary: View changes
Status: Needs review » Needs work
StatusFileSize
new37.38 KB
+++ b/core/themes/olivero/css/components/navigation/nav-secondary.pcss.css
@@ -66,6 +66,23 @@
+        height: var(--sp3);

Setting this to a fixed height results in text potentially overflowing the container, as seen in this screenshot. Unfortunately, there's a reasonable enough chance that this might occur to justify finding a solution that accommodates links with longer text content.

I was not able to thoroughly check every change, but noticed this during a brief review and wanted to be sure it was reported.

sagarchauhan’s picture

Status: Needs work » Needs review

The long text bug is a good catch but this issue is specific to the color of the focus and that issue seems to be addressed by the previous patch. Hence I would recommend to open a separate issue for it, to avoid increasing the scope of this issue.

vikashsoni’s picture

StatusFileSize
new26.59 KB
new27.68 KB

Applied patch #11 working fine and giving expected result
Thanks for the patch
for ref sharing screenshot....

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Shubham Sharma 77’s picture

StatusFileSize
new39.54 KB
new41.82 KB

Verified and tested patch #11 in drupal-9.5.x-dev.
Patch applied successfully and looks good to me.
Can be a move to RTBC.

Aamir M’s picture

Assigned: Unassigned » Aamir M
Aamir M’s picture

Assigned: Aamir M » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new133.52 KB
new14.74 KB
new14.47 KB
new14.38 KB
new14.13 KB

Verified and tested patch #11 on Drupal 9.5.x-dev. Patch applied successfully and looks good to me.

Testing steps:
1. Go to admin/Appearance
2. Set Olivero theme in the Administration theme (Scroll down and see)
3. Save configuration
4. Check on the responsive layout (Mobile)
5. Observe the My account and Log out focus color not matching with other items
5. Apply the patch
6. Reload the page. Now check, that the My account and Log out focus color match with other items

Testing Result:
1. After applying the patch the My account and Log out focus color match with other items

Can be moved to RTBC

gauravvvv’s picture

mherchel’s picture

Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs work

I personally don't think this is even a bug.

That being said, the patch in #11 uses pseudo-elements. Is there a reason why?

If we do change this, we really only need to modify the color of the current outline.

rakhi soni’s picture

Status: Needs work » Needs review
StatusFileSize
new1.1 KB

Kindly review patch for version 9.5x,,

ranjith_kumar_k_u’s picture

StatusFileSize
new1.05 KB
new620 bytes
aarti zikre’s picture

#30 Patch applied successfully and looks good to me.

Testing Steps:
# Goto any Responsiveness devices (Mobile, iPad)
# Goto: Appearance -> Install Olivero theme.
# Go to Homepage -> Click on hamburger menu
# Press Tab key and check the focus color which is not matching for My account and a logout button.

Expected Results:
# Focus color for My account and a logout button should match with other items.

Actual Results:

# My account and logout focus color not matching with other items

Looks good to me.
Can be a move to RTBC.

Screen short for reference:

Before patch
2022-08-03/3211562 before patch home_0.png
2022-08-03/3211562 before patch logout_0.png

After Patch
2022-08-03/3211562 after patch logout_0.png

aarti zikre’s picture

Status: Needs review » Reviewed & tested by the community
lauriii’s picture

Status: Reviewed & tested by the community » Closed (works as designed)

AFAIK this is how the focus ring in Olivero is designed to work. This is confirmed by @mherchel who is a subsystem maintainer of Olivero in #28.