Olivero: my account focus color not matching with other items
Steps to reproduce:
1. go to the main navigation accounts menu.
2. Focus on my account and log out.
3. Working fine on the desktop screen.
4. Issue is below 1200px screen on mobile and tab devices. Added screenshot for reference.
| Comment | File | Size | Author |
|---|---|---|---|
| #31 | 3211562 before patch home.png | 8.04 KB | aarti zikre |
| #31 | 3211562 before patch logout.png | 7.75 KB | aarti zikre |
| #31 | 3211562 after patch logout.png | 7.85 KB | aarti zikre |
| #31 | 3211562 before patch home.png | 98.45 KB | aarti zikre |
| #31 | 3211562 before patch logout.png | 103.25 KB | aarti zikre |
Comments
Comment #2
gauravvvv commentedI have provided the patch. please verify.
I have updated the focus color, added an after-patch screenshot for reference.
Comment #3
gauravvvv commentedComment #4
gauravvvv commentedRe-rolled patch #2.
Comment #5
gauravvvv commentedComment #6
abhijith s commentedApplied patch #2 and it works My account and logout links.
Before patch:

After patch:

Comment #7
gauravvvv commentedI have attached a patch which cover's login link too. please review.
Comment #8
gauravvvv commentedComment #10
sakthivel m commented#7 Patch failed
Comment #11
sakthivel m commented#11 please review the patch
Comment #12
chetanbharambe commentedComment #13
guilhermevp commentedPatch works as intended.
Tested in a Ipad screen (768x1024)
Home focus:

My account and Log Out Focus before:

My accout and Log Out focus after patch:

RTBC +1
Comment #14
chetanbharambe commentedVerified and tested patch #11.
Patch applied successfully and looks good to me.
Testing Steps:
# Goto any Responsiveness devices (Mobile, iPad)
# Goto: Appearance -> Install Olivero theme.
# Go to Homepage -> Click on hamburger menu
# Press Tab key and check the focus color which is not matching for My account and a logout button.
Expected Results:
# Focus color for My account and a logout button should match with other items.
Actual Results:
# My account and logout focus color not matching with other items
Looks good to me.
Can be a move to RTBC.
Comment #15
catchComment #17
sagarchauhan commentedReran the test for #11. The previous test failing doesn't seem to be related to the patch. Reviewed the patch and found that it works correctly. RTBC + 1
Comment #18
sagarchauhan commentedComment #19
bnjmnmSetting this to a fixed height results in text potentially overflowing the container, as seen in this screenshot. Unfortunately, there's a reasonable enough chance that this might occur to justify finding a solution that accommodates links with longer text content.
I was not able to thoroughly check every change, but noticed this during a brief review and wanted to be sure it was reported.
Comment #20
sagarchauhan commentedThe long text bug is a good catch but this issue is specific to the color of the focus and that issue seems to be addressed by the previous patch. Hence I would recommend to open a separate issue for it, to avoid increasing the scope of this issue.
Comment #21
vikashsoni commentedApplied patch #11 working fine and giving expected result
Thanks for the patch
for ref sharing screenshot....
Comment #24
Shubham Sharma 77 commentedVerified and tested patch #11 in drupal-9.5.x-dev.
Patch applied successfully and looks good to me.
Can be a move to RTBC.
Comment #25
Aamir M commentedComment #26
Aamir M commentedVerified and tested patch #11 on Drupal 9.5.x-dev. Patch applied successfully and looks good to me.
Testing steps:
1. Go to admin/Appearance
2. Set Olivero theme in the Administration theme (Scroll down and see)
3. Save configuration
4. Check on the responsive layout (Mobile)
5. Observe the My account and Log out focus color not matching with other items
5. Apply the patch
6. Reload the page. Now check, that the My account and Log out focus color match with other items
Testing Result:
1. After applying the patch the My account and Log out focus color match with other items
Can be moved to RTBC
Comment #27
gauravvvv commentedComment #28
mherchelI personally don't think this is even a bug.
That being said, the patch in #11 uses pseudo-elements. Is there a reason why?
If we do change this, we really only need to modify the color of the current outline.
Comment #29
rakhi soni commentedKindly review patch for version 9.5x,,
Comment #30
ranjith_kumar_k_u commentedComment #31
aarti zikre commented#30 Patch applied successfully and looks good to me.
Testing Steps:
# Goto any Responsiveness devices (Mobile, iPad)
# Goto: Appearance -> Install Olivero theme.
# Go to Homepage -> Click on hamburger menu
# Press Tab key and check the focus color which is not matching for My account and a logout button.
Expected Results:
# Focus color for My account and a logout button should match with other items.
Actual Results:
# My account and logout focus color not matching with other items
Looks good to me.
Can be a move to RTBC.
Screen short for reference:
Before patch


After Patch

Comment #32
aarti zikre commentedComment #33
lauriiiAFAIK this is how the focus ring in Olivero is designed to work. This is confirmed by @mherchel who is a subsystem maintainer of Olivero in #28.