Views migration from Drupal 7 to Drupal 9

Fixing fail tests, Added module 'Views' in StateFileExists file, Please have a look.

This is my very rough review (of #10):

1. +++ b/core/modules/views/src/Plugin/migrate/destination/ViewsMigration.php
   @@ -0,0 +1,30 @@
   +<?php
   +
   +namespace Drupal\views\Plugin\migrate\destination;
   +
   +use Drupal\migrate\Plugin\migrate\destination\EntityConfigBase;
   +use Drupal\migrate\Row;
   +
   +/**
   + * Drupal 8 views destination.
   + *
   + * @MigrateDestination(
   + *   id = "entity:view"
   + * )
   + */
   +class ViewsMigration extends EntityConfigBase {
   +
   +  /**
   +   * ViewsMigration import.
   +   *
   +   * @param Drupal\migrate\Row $row
   +   *   The views migration row.
   +   * @param array $old_destination_id_values
   +   *   Old destination id values.
   +   */
   +  public function import(Row $row, array $old_destination_id_values = []) {
   +    $entity_ids = parent::import($row, $old_destination_id_values);
   +    return $entity_ids;
   +  }
   +
   +}
   

   This destination plugin is now completely redundant.

2. +++ b/core/modules/views/src/Plugin/migrate/source/d7/ViewsMigration.php
   @@ -0,0 +1,534 @@
   + *   id = "d7_views",
   + *   source_module = "views"
   

   I miss the core annotation. And I'm almost sure that we'll need a mimimum schema version.

3. +++ b/core/modules/views/src/Plugin/migrate/source/d7/ViewsMigration.php
   @@ -0,0 +1,534 @@
   +class ViewsMigration extends FieldableEntity {
   

   This isn't using anything from FieldableEntity – let's extend DrupalSqlBase instead!

   Imho the source plugin should be named as "Views" instead of ViewsMigration".

As core sub-system maintainers for migrate, Michael Lutz (mikelutz), Benji Fisher (benjifisher), Vicki Spagnolo (quietone), and me (heddn) had some discussions recently about this proposal. Our suggestion is as follows and goes in line with how features as impactful as this are typically accepted into core these days.

To start, know that a migration path for views goes against the stream. For example, we already discussed this in #2500547: Upgrade path for Views from Drupal 6 and 7 and decided to punt. Getting it into core will be hard, mainly because it will be a lot of work.

Here's the greatest chance at success if you really want to get this into Drupal core:

• Open an ideas issue queue issue and start a sandbox or contrib project. It looks like the 2nd part of this is already done (see https://www.drupal.org/project/views_migration). We just need the first part. See https://www.drupal.org/project/ideas for more ideas on this process.
• Focus on improvements in contrib. You'll be able to move a _lot_ faster and get a lot of benefit for a lot of people in contrib.
• Make sure there is ample test coverage. If this is core-bound, testing is sometimes the hardest gate. So start out well in contrib.
• Once the module is hugely successful, then consider at that point if it makes sense to move into core.
• In the meantime, there's nothing stopping us from mentioning and promoting the module in drupal migration guides and blog posts.
• If there is areas you would value assistance from the migrate sub-system maintainers during this journey, don't hesitate to reach out.

@Jeya sundhar, thank you for opening an issue in the ideas project. And if you ever need review or testing in the Views migration from Drupal 6 or 7 to Drupal 9 project, ping me in #migration.

Postponing this on #3247281: Add views_migration to Drupal core.

Patch #15 no longer applied against 9.4.8. Here is a re-roll.

Migrate Drupal and Migrate Drupal UI have been approved for removal from core so this is now a won't fix. People wanting this functionality should look at the contrib project. The issue discussing the removal is #3371229: [Policy] Migrate Drupal and Migrate Drupal UI after Drupal 7 EOL