Edit article content image field alignment missing

CommentFileSizeAuthor
#20 Create_Article___Olivero.png126 KBmherchel
#19 Screenshot 2021-06-27 at 1.37.07 AM.png828.94 KBAgnesh Tank
#17 3210918-after-patch-view-page.png286.08 KBindrajithkb
#17 3210918-after-patch-edit-page.png48.08 KBindrajithkb
#16 Before_Patch_Screenshot 2021-06-11 at 6.23.26 PM.png361.48 KBAgnesh Tank
#16 After_patch_appliedScreenshot 2021-06-11 at 6.28.17 PM.png685.64 KBAgnesh Tank
#13 3210918-after.png44.46 KBabhijith s
#13 3210918-before.png44.58 KBabhijith s
#9 Screen Recording 2021-05-04 at 13.31.42.mov2.91 MBgauravvvv
#5 After patch image field displayed in proper alignment .png59.88 KBmanojithape
#5 Before patch Image field Alignment missing.png132.07 KBmanojithape
#2 3210918.2.patch2.9 KBsakthivel m
Screenshot 1943-02-07 at 5.19.04 PM.png136.13 KBsakthivel m

Issue fork drupal-3210918

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Sakthivel M created an issue. See original summary.

sakthivel m’s picture

sakthivel m commented
StatusFileSize
new 3210918.2.patch2.9 KB

#2 Please verify the patch

sakthivel m’s picture

sakthivel m commented
Status: Active » Needs review
gauravvvv’s picture

gauravvvv commented

we don't recommend using Olivero as an admin theme.

manojithape’s picture

manojithape commented
StatusFileSize
new Before patch Image field Alignment missing.png132.07 KB
new After patch image field displayed in proper alignment .png59.88 KB

Verified and tested patch#2. Patch applied successfully and looks good to me.

Testing Steps:

  1. Install drupal 9.2.x-dev version
  2. Go to Appearance -> Set Olivero theme as admin and default theme
  3. Go to Content and create one article content type
  4. Edit that newly created Article content type and observe on Edit article content image field alignment missing
  5. Now apply the patch and clear the cache and again go to edit article content type and verify image field alignment displayed properly as other fields.

Testing Results:
After applying the patch on edit article content type image field alignment displayed properly.

Moving this ticket to RTBC.

manojithape’s picture

manojithape commented
Status: Needs review » Reviewed & tested by the community

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs review

Has this been tested on the rendered node? It seems like these styles are targeted at that.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new Screen Recording 2021-05-04 at 13.31.42.mov2.91 MB

This is fixed in Drupal 9.3.x

Please review before patch screen recording. The alignment seems to be correct.

sakthivel m’s picture

sakthivel m commented

@Gauravmahlawat Issue still exits in Drupal 9.3.x, please verify in edit article content image field.

Rinku Jacob 13 made their first commit to this issue’s fork.

Rinku Jacob 13 opened merge request !627

abhijith s’s picture

abhijith s commented
StatusFileSize
new 3210918-before.png44.58 KB
new 3210918-after.png44.46 KB

Applied patch #2 on 9.3.x and it works fine.

Before patch:
before

After patch:
after

RTBC +1

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Closed (won't fix)

This issue is only when using Olivero as an admin theme, which is not supported. Closing as 'won't fix'

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Closed (won't fix) » Needs review

The node form is not considered to be part of admin UI because there are sites where exposing it to users is a valid use case (for example, DrupalCon website). It can be configured to be rendered using the FE theme in the appearance page.

Agnesh Tank’s picture

Agnesh Tank commented
Status: Needs review » Needs work
StatusFileSize
new After_patch_appliedScreenshot 2021-06-11 at 6.28.17 PM.png685.64 KB
new Before_Patch_Screenshot 2021-06-11 at 6.23.26 PM.png361.48 KB

Tested on 9.3.x-dev with Chrome Browser(Version 90.0.4430.212 (Official Build))

Status: FAIL (Issue persist)

Changing to : Needs work

Patch File used: 3210918.2.patch

Testing steps followed for the issue verification
Install drupal 9.3.x-dev version
Go to Appearance -> Set Olivero theme as admin and default theme
Go to Content and create one article content type
Edit that newly created Article content type and observe on Edit article content image field alignment missing
Now apply the patch and clear the cache and again go to edit article content type and verify image field alignment displayed properly as other fields.

Testing Results:
Even After applying the patch on edit article content type image field is still misaligned

indrajithkb’s picture

indrajithkb commented
StatusFileSize
new 3210918-after-patch-edit-page.png48.08 KB
new 3210918-after-patch-view-page.png286.08 KB

Hi @mherchel the issue is from very early stage of our theme (see the link ) if we are planning to fix this issue then am adding my findings here.

hi @Agnesh Tank thanks for testing, but unfortunately you have tested with some different theme not with olivero, that's why the issue still there.

Here i have tested with #2 patch . Thanks @Sakthivel M for the patch.

Adding screenshots

1. For edit node

image

Yes this is the expected solution.

2. For view node

image

This is not we are expecting , because according to our design (see the link) we need some negative margin for desktops.

So we need a solution with satisfying both points.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

I want to see if this is still an issue after #3173008: [Code Review] wide image within article template a reusable component/class gets committed.

Agnesh Tank’s picture

Agnesh Tank commented
StatusFileSize
new Screenshot 2021-06-27 at 1.37.07 AM.png828.94 KB

Hi @https://www.drupal.org/u/indrajith-kb I have tested with Olivero theme only.. and its reproducible on my local setup.... Please refer the below SS for the theme set as default & chrome browser

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs work » Closed (outdated)
StatusFileSize
new Create_Article___Olivero.png126 KB

This was fixed in #3173008: [Code Review] wide image within article template a reusable component/class