Problem/Motivation

doctrine/collections is missing from composer.json, yet the module is using Doctrine\Common\Collections\ArrayCollection. This causes dmu-upgrade to fail at times.

Proposed resolution

Add it.

Workaround

composer require doctrine/collections:^1.6.1

CommentFileSizeAuthor
#2 drupalmoduleupgrader-doctrine-collections-3210266-2.patch308 bytessolideogloria

Issue fork drupalmoduleupgrader-3210266

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

solideogloria created an issue. See original summary.

solideogloria’s picture

solideogloria commented
Status: Active » Needs review
StatusFileSize
new drupalmoduleupgrader-doctrine-collections-3210266-2.patch308 bytes
solideogloria’s picture

solideogloria commented
Issue summary: View changes
solideogloria’s picture

solideogloria commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Is this change compatible with D9 ?

solideogloria’s picture

solideogloria commented

Yes, I'm using Drupal 9.1

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Reviewed & tested by the community

lets get this in at next opportunity

ladybug_3777’s picture

ladybug_3777 commented

composer require doctrine/collections:^1.6.1 also worked for me on my Drupal version 9.1.10

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Reviewed & tested by the community » Fixed
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Fixed » Needs work

This broke the tests.. Recommend to maybe use ^1.4.0

jcnventura opened merge request !2

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs work » Needs review

  • jcnventura committed c1746a8 on 8.x-1.x 
    Issue #3210266 by jcnventura: Use doctrine/collections 1.4 or higher to...
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Fixed
jcnventura’s picture

jcnventura
Primary language English
commented

Tests passed. Committed so that we have tests running again.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.