Problem/Motivation

After the resounding success *cough* of #3209306: Speed up FunctionalJavascriptTests tests, let's do it correct this time.

Proposed resolution

Try to get the current $this->assertNotEmpty($assert_session->waitForElementRemoved('xpath', $whatever)); to look for the quickest element to wait for.

Issue fork inline_entity_form-3209349

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !27

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review

Last run on inline_entity_form 8.x-1.x-dev branch:

00:04:45.221 Test summary
00:04:45.221 ------------
00:04:45.221 
00:05:03.030 Drupal\Tests\inline_entity_form\FunctionalJavascript\Transla   1 passes                                      
00:05:03.030 Drupal\Tests\inline_entity_form\FunctionalJavascript\SimpleW   4 passes                                      
00:05:49.440 Drupal\Tests\inline_entity_form\FunctionalJavascript\Element   1 passes                                      
00:06:02.229 Drupal\Tests\inline_entity_form\FunctionalJavascript\Complex  14 passes                                      
00:09:25.146 Drupal\Tests\inline_entity_form\FunctionalJavascript\Complex   4 passes                                      
00:12:39.436 Drupal\Tests\inline_entity_form\FunctionalJavascript\Complex   1 passes                                      
00:12:55.878 
00:12:56.105 Test run duration: 8 min 10 sec

After (this MR, ran twice):

00:04:48.697 Test summary
00:04:48.697 ------------
00:04:48.697 
00:05:06.684 Drupal\Tests\inline_entity_form\FunctionalJavascript\Transla   1 passes                                      
00:05:06.684 Drupal\Tests\inline_entity_form\FunctionalJavascript\SimpleW   4 passes                                      
00:05:53.921 Drupal\Tests\inline_entity_form\FunctionalJavascript\Element   1 passes                                      
00:06:07.226 Drupal\Tests\inline_entity_form\FunctionalJavascript\Complex  14 passes                                      
00:09:34.030 Drupal\Tests\inline_entity_form\FunctionalJavascript\Complex   4 passes                                      
00:10:50.086 Drupal\Tests\inline_entity_form\FunctionalJavascript\Complex   1 passes                                      
00:11:07.237 
00:11:07.238 Test run duration: 6 min 18 sec

and

00:04:10.750 Test summary
00:04:10.750 ------------
00:04:10.750 
00:04:28.888 Drupal\Tests\inline_entity_form\FunctionalJavascript\Transla   1 passes                                      
00:04:28.888 Drupal\Tests\inline_entity_form\FunctionalJavascript\SimpleW   4 passes                                      
00:05:17.069 Drupal\Tests\inline_entity_form\FunctionalJavascript\Element   1 passes                                      
00:05:30.262 Drupal\Tests\inline_entity_form\FunctionalJavascript\Complex  14 passes                                      
00:08:59.408 Drupal\Tests\inline_entity_form\FunctionalJavascript\Complex   4 passes                                      
00:10:16.303 Drupal\Tests\inline_entity_form\FunctionalJavascript\Complex   1 passes                                      
00:10:33.441 
00:10:33.688 Test run duration: 6 min 22 sec

Good enough for me :)

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned

podarok made their first commit to this issue’s fork.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 8.x-1.x-dev » 2.0.x-dev
Status: Needs review » Fixed

tnx

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Version: 2.0.x-dev » 3.x-dev
Status: Closed (fixed) » Needs review
Related issues: +#3401656: Clean up problematic 2.x branch

Bulk reopen.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Needs review » Reviewed & tested by the community

Reviewed with good faith in @Spokjes test wizardry.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.