Problem/Motivation

The API call to retrieve the total number of items to migrate does not take into account pagination returned by the GatherContent API as specified in the GC API here: https://docs.gathercontent.com/reference#listitems

Steps to reproduce

Attempt to migrate from any template with more than 100 items.

Proposed resolution

Fix GatherContentClient to retrieve all items.

Remaining tasks

Patch coming[

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#3 before-and-after-gc-api-issue.png59.73 KBscott_euser

Issue fork gathercontent-3208872

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_euser created an issue. See original summary.

scott_euser opened merge request !2

scott_euser’s picture

scott_euser commented
Assigned: scott_euser » Unassigned
Status: Active » Needs review
StatusFileSize
new before-and-after-gc-api-issue.png59.73 KB

Merge request diff:
https://git.drupalcode.org/project/gathercontent/-/merge_requests/2/diffs

Before and after patch:

scott_euser’s picture

scott_euser commented
Title: Critical: Maximum of 100 items are migrated per template only » Maximum of 100 items are migrated per template only
Priority: Critical » Major

Actually probably major rather than critical sorry - doesn't render site unusable, just the feature has no valid/reasonable workaround.

gdeni’s picture

gdeni commented
Assigned: Unassigned » gdeni
Status: Needs review » Reviewed & tested by the community

Thanks for your report and fix! I've tested it, works properly!

  • gdeni committed 2708ce7 on 8.x-5.x authored by scott_euser 
    Issue #3208872 by scott_euser: Maximum of 100 items are migrated per...
scott_euser’s picture

scott_euser commented
Status: Reviewed & tested by the community » Fixed

Thanks!

gdeni’s picture

gdeni commented
Assigned: gdeni » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.