To reproduce

  1. Use Safari browser
  2. Open Olivero
  3. Set browser width to tablet width (~800px) where the "Menu" text is visible
  4. Click and hold the menu button (this activates the :active state)
  5. Note that the text turns white.

We need to define an :active state that inherits the current text. Be sure to add a code comment on why it's being added.

CommentFileSizeAuthor
#3 Screen Recording 2021-04-17 at 19.34.34.mov4.96 MBgauravvvv
#2 3208114.patch1.1 KBmherchel
safari-button-active.gif1.25 MBmherchel

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Needs review
StatusFileSize
new 3208114.patch1.1 KB

Quick and easy patch attached.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new Screen Recording 2021-04-17 at 19.34.34.mov4.96 MB

Text Fluctuation has been fixed by patch #2, Adding after patch screen recording for ref.

Moving to RTBC

gauravvvv’s picture

gauravvvv commented
Status: Needs review » Reviewed & tested by the community
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

Reviewed the code and tested manually with desktop Safari. This looks good, so I'll get back to this after the code freeze for the security window has ended.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3208114.patch, failed testing. View results

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs work » Reviewed & tested by the community

Test failure is unrelated.

  • lauriii committed e3d8787 on 9.2.x 
    Issue #3208114 by mherchel, Gauravmahlawat: Olivero: Menu button text...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed e3d8787 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.