Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
To reproduce
- Use Safari browser
- Open Olivero
- Set browser width to tablet width (~800px) where the "Menu" text is visible
- Click and hold the menu button (this activates the
:active
state) - Note that the text turns white.
We need to define an :active
state that inherits the current text. Be sure to add a code comment on why it's being added.
Comment | File | Size | Author |
---|---|---|---|
#3 | Screen Recording 2021-04-17 at 19.34.34.mov | 4.96 MB | Gauravvvv |
#2 | 3208114.patch | 1.1 KB | mherchel |
safari-button-active.gif | 1.25 MB | mherchel |
Comments
Comment #2
mherchelQuick and easy patch attached.
Comment #3
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for DrupalFit commentedText Fluctuation has been fixed by patch #2, Adding after patch screen recording for ref.
Moving to RTBC
Comment #4
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for DrupalFit commentedComment #5
lauriiiReviewed the code and tested manually with desktop Safari. This looks good, so I'll get back to this after the code freeze for the security window has ended.
Comment #7
mherchelTest failure is unrelated.
Comment #9
lauriiiCommitted e3d8787 and pushed to 9.2.x. Thanks!