Problem/Motivation

Comment for menu_ui_form_node_type_form_alter() has @see menu_ui_form_node_type_form_submit() which is a function that does not exist. The saving of the form fields added in this alter happens in menu_ui_form_node_type_form_builder().

/**
 * Implements hook_form_FORM_ID_alter() for \Drupal\node\NodeTypeForm.
 *
 * Adds menu options to the node type form.
 *
 * @see NodeTypeForm::form()
 * @see menu_ui_form_node_type_form_submit()
 */
function menu_ui_form_node_type_form_alter(&$form, FormStateInterface $form_state) {

Steps to reproduce

N/A

Proposed resolution

Update function comment.

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

Fix comment for menu ui node type form alter.

CommentFileSizeAuthor
#18 reroll_diff_16-18.txt473 bytesimmaculatexavier
#18 3207771-18.patch651 bytesimmaculatexavier
#16 3207771-16.patch657 bytesravi.shankar
#12 3207771-12.patch657 bytesquietone
#11 3207771-11.patch658 bytesquietone

Issue fork drupal-3207771

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_euser created an issue. See original summary.

scott_euser opened merge request !511

scott_euser opened merge request !512

scott_euser closed merge request !511

idebr’s picture

idebr commented
Status: Active » Needs review
scott_euser’s picture

scott_euser commented

Thanks @idebr, still getting used to the steps for MRs :)

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Issue tags: +Bug Smash Initiative

Triaging for Bug Smash.

Indeed, menu_ui_form_node_type_form_submit does not exist in core. I think this is fine, just need to get it testing against 9.3.x I think.

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

Let's see if the tests will run.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3207771-11.patch658 bytes

I was trying to change the target branch to 9.4 but, well, failed. It doesn't help that the command to checkout the branch git checkout -b '9.2.x' --track drupal-3207771/'9.2.x' is trying to create '9.2.x'.

So I just made a patch. It is only one line.

quietone’s picture

quietone commented
StatusFileSize
new 3207771-12.patch657 bytes

Start over, again.

scott_euser opened merge request !1948

scott_euser’s picture

scott_euser commented

I updated the merge request to 9.4.x (I guess that's what you were after). Hopefully tests run now. I don't quite get why your patch approach doesn't work. Ultimately here's what I did to bring in the 9.4.x:

git remote add upstream git@git.drupal.org:project/drupal.git
git fetch upstream
git checkout 9.4.x
git merge upstream/9.4.x 9.4.x
git cherry-pick 2e2affed413b501fc2cd70d0107c7754a2d44177
git push origin 9.4.x

Then recreated the merge request.

joachim’s picture

joachim commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

There seems to be a problem with the patch and MR. They look good, but failing to apply/merge.

ravi.shankar’s picture

ravi.shankar commented
StatusFileSize
new 3207771-16.patch657 bytes

Added a reroll.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

immaculatexavier’s picture

immaculatexavier commented
Status: Needs work » Needs review
StatusFileSize
new 3207771-18.patch651 bytes
new reroll_diff_16-18.txt473 bytes

Rerolled patch against 9.5
Attached reroll against #16

joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

  • catch committed 1615365 on 10.0.x 
    Issue #3207771 by scott_euser, quietone, immaculatexavier, ravi.shankar...
  • catch committed 8743ce6 on 10.1.x
    Issue #3207771 by scott_euser, quietone, immaculatexavier, ravi.shankar...
  • catch committed 142860a on 9.4.x
    Issue #3207771 by scott_euser, quietone, immaculatexavier, ravi.shankar...
  • catch committed 2db9c97 on 9.5.x
    Issue #3207771 by scott_euser, quietone, immaculatexavier, ravi.shankar...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked back through to 9.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.