Closed (outdated)
Project:
Address Autocomplete
Version:
1.0.0-beta2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Mar 2021 at 12:27 UTC
Updated:
28 May 2025 at 23:28 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
minnur commentedComment #3
minnur commentedAlso for US addresses the street number should be in front of the street name. e.g. 11 Main Street.
Comment #4
superlolo95 commentedIf the street number is empty, the street name should not be preceeded by a blank character.
$results[$key]["street_name"] = (!empty($streetNumber) ? $streetNumber : "") . " " . $street_name;
should be more
$results[$key]["street_name"] = (!empty($streetNumber) ? $streetNumber . " " : "") . $street_name;
Comment #5
dejan0 commentedThanks, @minnur and @superlolo95, I will test it!
Comment #6
lazzyvn commentedSome country have format address like this [Street number] [street name]
not [Street name], [Street number]
so we must have code country to detect
here is list
$country_format_special = ['FR','CA','IE','IN','IL','HK','MY','OM','NZ','PH','SA','SE','SG','LK','TH','UK','US','VN'];
i think there is some country have to swap state vs city name the list can be found in module address
for more information https://fr.wikipedia.org/wiki/Adresse_postale
Comment #7
minnur commented@lazzyvn that makes sense, probably it would be best to create a separate plugin for US addresses. Or maybe refine logic and present addresses based on its address
Comment #8
rhovlandThere's no need to change the name of the town name key so I removed that from the patch
Comment #9
socialnicheguru commentedComment #10
socialnicheguru commentedthe widget does not fill in the state when I select the US.
This patch fixes states not being selected or filled in: Administrative area is not handled
Comment #11
lazzyvn commentedyou can use my module address suggestion more feature and config provider in widget
Comment #12
criz@lazzyvn Why did you fork this module? Does not make any sense. :( We don't have always time to test/commit merge requests immediately, but this module is definitely not abandoned. We can also add you as maintainer if you are interested.
Comment #13
lazzyvn commentedBecause my logic is not the same. I want the config provider in the widget not in the module config
Comment #14
criz@lazzyvn Then I would suggest to create an issue about this (add configuration for provider also in the widget). I don't think its good to have two modules, just with different places where configuration is done. And tell us if you want to be added as maintainer.
Comment #15
lazzyvn commentedOh I made a lot of merge requests but over a year ago no one approved them. There are a lot of bugs and the community made a lot of patch but no one listens feedback to fix or add to dev. So i think it's so hard to request a new feature.
This module is still in beta, so I can't add module with composer to drupal 9,this is a reason why i decided to create a new module i change 80% of the code i just keep 2 file providers(Swiss Post and Google Maps)
Comment #16
socialnicheguru commentedthis patch is needed along with https://www.drupal.org/project/address_autocomplete/issues/3226560
Comment #17
klonos#3226560: Commas in an address breaks autocomplete and #3260954: Administrative area is not handled were recently committed to the latest dev version (along with some other commits), so the patch in #8 doesn't apply any longer.
Comment #18
klonos...testing the latest dev version, I confirm that things work properly now:
What I have noticed is that:
Anyway, my point is that people should test the latest dev version, and then confirm if the originally-reported issue here still applies. If not, then I believe that we should close this issue here, and open separate, new issues for each problem - keeping all problems in a single issue does not help.
Comment #19
rhovlandThe google maps provider was rewritten and I'm not seeing any of these problems with it. Closing as outdated. Please reopen if you can reproduce any of these issues in the latest release.