Needs work
Project:
Drupal core
Version:
main
Component:
views.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Mar 2021 at 13:36 UTC
Updated:
4 Sep 2025 at 08:07 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sroy26 commentedPlease find the following patch for the issue.
Comment #3
sroy26 commentedComment #4
bhumikavarshney commentedPatch #2 is nice. Thx for that.
It works for me.
Now, If both Min & Max date are entered, results are returned within the range selected. If either are missing, all results are returned this condition is working as expected.
Comment #5
mitthukumawat commentedPatch #2 applied cleanly on drupal 9.x.3-dev version for me and resolved the issue.
Thanks for the patch.
Comment #6
raphael apard commentedThis is only working if we set MAX with empty MIN.
With MIN set and empty MAX, the condition is "BETWEEN MIN_DATE AND 0" so there is no result.
When only min is set, condition should be ">= $a" and not "BETWEEN $a AND $b"
Comment #7
hhvardan commentedThe patch doesn't work if the min value exists and max is empty.
Comment #8
hhvardan commentedComment #9
hhvardan commentedComment #10
hhvardan commentedComment #11
ranjith_kumar_k_u commentedFixed CS issues
Comment #14
golddragon007 commentedThe patch was not complete, so I added support for datetime module, and not between operations.
And added a related issue from the integer filter variant.
I removed this:
As it makes no sense currently for me, in that moment and time we have a string date, and not a timestamp.
Originates from: https://www.drupal.org/project/drupal/issues/2627512
Comment #15
golddragon007 commentedComment #16
golddragon007 commentedWrong condition fix when both times set.
Comment #17
dsdeiz commentedYeah, works on my end. I've added the tests.
Comment #18
dsdeiz commentedComment #20
dsdeiz commentedComment #21
vikashsoni commentedApplied patch #2 in drupal-9.3.x-dev applied successfully and fix the issue
Thanks for the patch
for ref sharing screenshot...
Comment #22
golddragon007 commented#18 tested and looks fine.
Comment #24
quietone commentedThanks for fixing this.
This needs to be on 10.0.x now, changing version. The patch includes a test so removing tag.
A brief look at the patch and I notices these two items.
I think this should be max.
This comment should now be above the whole if block since it applies to all 3 paths.
I applied the patch to 9.5.x and did some testing. I added a date field to the article content type and then made a view with two exposed filters, one on the added date field and the other on the authored on field. I used devel generated content with authored dates going back for a year. I added a date to two node.
I did not do exhaustive testing. The date field appeared to work with offset and date. The authored on field worked with dates but failed with just a minimum offset. And min offset of '-3 days' failed to show any nodes but a min of '-3 days' and a max of '-2 days' would show the correct nodes.
Setting to NW.
Comment #25
suresh prabhu parkala commentedI tried to fix the changes mentioned in #24. Please have a look.
Comment #26
smustgrave commentedThis issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.
The issue summary needs to be updated with proposed solution.
CI failures in #25
Comment #27
simobm commentedIt's weird, i've tried all of the patches and none seems to works, i've tried on 9.3.22 , 9.4.11 and 9.5.3.
I'm getting the same results as @hhvardan and #Raphael Apard only max works alone, if i use only min i get no results.
Comment #28
camilo.escobar commentedThis issue is also solved in https://www.drupal.org/node/2982968
Comment #29
s3b0un3tHello,
@camilo.escobar : I've try to use your patch in issue #2982968 but it's return an error.
I will add a comment on your issue in order to trace the error.
The patch #25 seems to work on Drupal 10.2.2.
Cheers.
Comment #31
khiminrm commentedPatch from #25 also works for me on Drupal 10.2.6
Comment #32
gun_dose commentedUpdated patch that applies to Drupal 11.2