Problem/Motivation

  • Handle uid by adding a tag to each OpenStack resource
CommentFileSizeAuthor
#35 3201330-35.patch55.73 KByas
#33 3201330-33.patch55.57 KByas
#32 3201330-32.patch55.73 KByas
#25 3201330-24.patch55.73 KByas
#21 3201330-21.patch56.51 KBjigish.addweb
#18 3201330-18.patch56.52 KBjigish.addweb
#14 3201330-14.patch53.54 KBjigish.addweb
#13 3201330-13.patch53.49 KBjigish.addweb
#9 3201330-9.patch53.49 KBjigish.addweb
#7 3201330-7.patch47.05 KBjigish.addweb
#6 3201330-6.patch23.38 KBjigish.addweb
#5 3201330-5.patch19.53 KBjigish.addweb
#3 3201330-3.patch18.87 KBjigish.addweb

Issue fork cloud-3201330

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb opened merge request !169

jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
StatusFileSize
new 3201330-3.patch18.87 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@jigishaddweb

Thank you for adding the feature. I posted my comments. Thanks

jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
StatusFileSize
new 3201330-5.patch19.53 KB

@yas

Thank you for your review.

I resolved all testcase errors. Please review the updated patch.

Thanks

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3201330-6.patch23.38 KB
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3201330-7.patch47.05 KB

@yas

I implemented tags functionality in all OpenStack Rest Resources.
Please review the updated patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@jigishaddweb

Thank you for the update. I posted my comments. Please check. Thanks.

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3201330-9.patch53.49 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
jigish.addweb’s picture

jigish.addweb commented

@yas @sekinet Thank you for your review.

I refactored the code and added comments in some threads.

Please review the updated patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@jigishaddweb

Thank you for the update. I have one minor comment. Please check. Thanks

jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
StatusFileSize
new 3201330-13.patch53.49 KB

@yas Thank you for your review.

I changed the doc comment as per your suggestion.

Thanks

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3201330-14.patch53.54 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@jigishaddweb

Thank you for the update.

@sekinet

Could you please review the patch?

Thanks

Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
Assigned: jigish.addweb » Unassigned

From #15, unassigning.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Assigned: Unassigned » jigish.addweb
Status: Needs review » Needs work

@jigishaddweb

Thank you for the update. We found an issue when updating a tag in the resource such as Image, Security Group, Floating IP, and Network Interface. Please check the issue and fix it.

jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
StatusFileSize
new 3201330-18.patch56.52 KB

@yas

Thank you for testing the patch.

I updated the code for updating the tags in Image, Security Group, Floating IP, and Network Interface of OpenStack resources.

Please test the updated patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@jigishaddweb

Thank you for the update. I tested the patch and it looks good to me now. I'll change the status of this issue to RTBC. Please let us hold this patch until we create the 4.x branch. Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@jigishaddweb

I posted my comment. Thanks.

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3201330-21.patch56.51 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review

@yas

I resolved alignment issue. Please review the updated patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@jigishaddweb

Thank you for the quick update. I change back to RTBC. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Assigned: jigish.addweb » yas
Status: Reviewed & tested by the community » Needs work

@all

The patch is now behind against HEAD. I'll take over to fix and change the status to Needs work. Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3201330-24.patch55.73 KB

@all

Rebased, resolved conflicts.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Version: 3.x-dev » 4.x-dev
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@all

The patch is now behind against HEAD on 4.x branch. I'll take over to fix and change the status to Needs work. Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Version: 4.x-dev » 3.x-dev
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Version: 3.x-dev » 4.x-dev
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3201330-32.patch55.73 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3201330-33.patch55.57 KB

Merged 4.x to the branch

Status: Needs review » Needs work

The last submitted patch, 33: 3201330-33.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3201330-35.patch55.73 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@all

The tests have been passed successfully, so I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed fc0a9bb on 4.x 
    Issue #3201330 by yas, jigish.addweb: Handle uid by adding a tag to each...

yas closed merge request !169

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.