Problem/Motivation

Using Drupal 8.9 in mobile, in the view settings page, the Save and the Cancel buttons are closer than they should be.

Steps to reproduce

  • Create a view from a mobile device
  • Find the Save and Cancel buttons in the views setting page

Proposed resolution

There should be some gap between those buttons.

CommentFileSizeAuthor
#43 70251da45e8231e5d94ad7e29686e9ab83f3a558.png15.92 KBavpaderno
#32 3201325-32.patch456 bytesdjsagar
#29 After Patch 3201325 Android up.png269.31 KBchetanbharambe
#29 After Patch 3201325 iPhone up.png269.63 KBchetanbharambe
#29 Before Patch 3201325 iPhone up.png281.15 KBchetanbharambe
#29 Before Patch 3201325 Android up.png276.78 KBchetanbharambe
#28 afterpatch.png64.84 KBrinku jacob 13
#28 beforepatch.png70.63 KBrinku jacob 13
#23 After Patch 3201325 iPhone.png307.26 KBchetanbharambe
#23 After Patch 3201325 Android.png243.58 KBchetanbharambe
#23 Before Patch iPhone 3201325.png232.88 KBchetanbharambe
#23 Before Patch 3201325 Android.png222.94 KBchetanbharambe
#20 buttons-issue-3201325-20.patch456 bytestanmaykadam
#17 AP 3201325-17.png123.89 KBtanmaykadam
#17 BP 3201325-17.png123.93 KBtanmaykadam
#15 interdiff_13-15.txt697 bytesdjsagar
#15 After-patch.png64.19 KBdjsagar
#15 3201325-15.patch5.59 KBdjsagar
#14 before-patch.png408.5 KBdjsagar
#14 After-patch.png58.5 KBdjsagar
#13 3201325-12.patch5.58 KBgauravvvv
#12 3201325-11.patch6.39 KBgauravvvv
#11 3201325-11.patch6.39 KBbhumikavarshney
#10 After-patch-viewmobile.png60.16 KBMadhu kumar
#7 before.png61.94 KBadalbertov
#7 after.png52.29 KBadalbertov
#5 3201325-after-patch.png32.35 KBindrajithkb
#5 3201325-before-patch.png31.91 KBindrajithkb
#3 3201325-2.patch5.51 KBabhijith s
#2 3201325-1.patch6.3 KBbhumikavarshney
Screenshot_2021-03-03-10-31-27-91.jpg365.11 KBkumar ashutosh

Issue fork seven-3201325

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Kumar Ashutosh created an issue. See original summary.

bhumikavarshney’s picture

bhumikavarshney commented
Status: Active » Needs review
StatusFileSize
new 3201325-1.patch6.3 KB

I have created a patch regarding this issue.
Please review

abhijith s’s picture

abhijith s commented
StatusFileSize
new 3201325-2.patch5.51 KB

Fixed custom commands fail issue in patch #1.

indrajithkb’s picture

indrajithkb commented
Assigned: Unassigned » indrajithkb
indrajithkb’s picture

indrajithkb commented
StatusFileSize
new 3201325-before-patch.png31.91 KB
new 3201325-after-patch.png32.35 KB

HI @Abhijith S thanks for the patch, i have applied the patch successfully and it's working as expected. Attaching the screenshot before and after the patch applied.

Before patch

before patch

After Patch

after patch

Adding RTBC +1

indrajithkb’s picture

indrajithkb commented
Assigned: indrajithkb » Unassigned
adalbertov’s picture

adalbertov commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after.png52.29 KB
new before.png61.94 KB

Hello people, i have reviewed the patch #3 has well. The changes seemed ok for me, and the patch worked too so I'm moving the issue to RTBC. (Also adding the print of before and after the patch)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 3201325-2.patch, failed testing. View results

indrajithkb’s picture

indrajithkb commented
Status: Needs work » Needs review
Madhu kumar’s picture

Madhu kumar commented
StatusFileSize
new After-patch-viewmobile.png60.16 KB

Patch #3 is applied cleanly and working as expected , but there is one more issue where the page title is too long it will go out of the screen. sharing screenshot for reference.

bhumikavarshney’s picture

bhumikavarshney commented
StatusFileSize
new 3201325-11.patch6.39 KB
gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3201325-11.patch6.39 KB

Rerolled patch #11.

Needs review.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3201325-12.patch5.58 KB
djsagar’s picture

djsagar commented
Status: Needs review » Needs work
StatusFileSize
new After-patch.png58.5 KB
new before-patch.png408.5 KB

After patch 3201325-12.patch applied cleanly and working as expected, but there is one more issue which i found, top and bottom space is not not equal as it before for more info please check the attachment.

There is also "Unexpected missing end-of-source newline" issue on this patch.

And interdiff is also missing.

Thanks!

djsagar’s picture

djsagar commented
Status: Needs work » Needs review
StatusFileSize
new 3201325-15.patch5.59 KB
new After-patch.png64.19 KB
new interdiff_13-15.txt697 bytes

I re-uploading the patch with interdiff and also it's resolved issue which i mentioned on comment #15.

Please review.

Thanks!

tanmaykadam’s picture

tanmaykadam commented
Assigned: Unassigned » tanmaykadam
tanmaykadam’s picture

tanmaykadam commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new BP 3201325-17.png123.93 KB
new AP 3201325-17.png123.89 KB

Before applying the patch

After applying the patch

Verified and tested patch #21.
Patch applied successfully and looks good to me.

Testing steps:
# Goto: /admin/structure/views/view/block_content
# View buttons save and cancel for the mobile device should not stick to each other.

Looks good to me.
Please refer attached screenshots for Before and After patch.

tanmaykadam’s picture

tanmaykadam commented
Assigned: tanmaykadam » Unassigned
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Title: In mobile screen buttons get too closed » In mobile screen buttons get too close
Version: 8.9.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Needs work

Can we tidy up the patch to only change the necessary parts to fix the bug?

tanmaykadam’s picture

tanmaykadam commented
Assigned: Unassigned » tanmaykadam
StatusFileSize
new buttons-issue-3201325-20.patch456 bytes

@lauriii
Considering comment #19
I have updated the patch.
Please review the patch.

tanmaykadam’s picture

tanmaykadam commented
Assigned: tanmaykadam » Unassigned
Status: Needs work » Needs review
chetanbharambe’s picture

chetanbharambe commented
Assigned: Unassigned » chetanbharambe
chetanbharambe’s picture

chetanbharambe commented
StatusFileSize
new Before Patch 3201325 Android.png222.94 KB
new Before Patch iPhone 3201325.png232.88 KB
new After Patch 3201325 Android.png243.58 KB
new After Patch 3201325 iPhone.png307.26 KB

Verified and tested patch #20.
Patch applied successfully and looks good to me.

Testing Steps:
# Go to any Responsiveness device.
# Goto: admin/structure/views/view/content
# Check Save and Cancel button

Expected Results:
# After Applying Patch, the User should see the Margin between Save and Cancel button.

Actual Results:
# Before Applying Patch, the User is able to see Save and Cancel buttons getting too Close.

Looks good to me.
Can be a move to RTBC.

chetanbharambe’s picture

chetanbharambe commented
Assigned: chetanbharambe » Unassigned
Status: Needs review » Reviewed & tested by the community

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 20: buttons-issue-3201325-20.patch, failed testing. View results

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review

Restoring status after HEAD was broken.

rinku jacob 13’s picture

rinku jacob 13 commented
StatusFileSize
new beforepatch.png70.63 KB
new afterpatch.png64.84 KB

Verified and tested patch#20 on the drupal 9.3.x-dev version. Patch applied successfully and looks good to me.Adding screenshot for the reference.

chetanbharambe’s picture

chetanbharambe commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before Patch 3201325 Android up.png276.78 KB
new Before Patch 3201325 iPhone up.png281.15 KB
new After Patch 3201325 iPhone up.png269.63 KB
new After Patch 3201325 Android up.png269.31 KB

Verified and tested patch #20.
Patch applied successfully and looks good to me.

Testing Steps:
# Go to any Responsiveness device.
# Goto: admin/structure/views/view/content
# Check Save and Cancel button

Expected Results:
# After Applying Patch, the User should see the Margin between Save and Cancel button.

Actual Results:
# Before Applying Patch, the User is able to see Save and Cancel buttons getting too Close.

Looks good to me.
Can be a move to RTBC.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Bug Smash Initiative

The patch in this issue is for 9.2.x and there are failing tests, it needs to be updated to 9.4.x.

@chetanbharambe, it helps reviewers if the before and after screenshots are included in the IS, a link to the file is fine. Check before posting screenshots, you have posted two sets on the same patch #20.

djsagar’s picture

djsagar commented
Status: Needs work » Needs review
StatusFileSize
new 3201325-32.patch456 bytes

Rerolled patch #20.

Status: Needs review » Needs work

The last submitted patch, 32: 3201325-32.patch, failed testing. View results

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Project: Drupal core » Seven
Version: 9.5.x-dev » 1.0.0-alpha1
Component: Seven theme » Code

The Seven theme has been removed from Drupal 10 core. I confirmed that this issue only affects Seven and no other themes included with Drupal core, so I am moving this to the contributed Seven project.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 1.0.0-alpha1 » 1.0.x-dev
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: In mobile screen buttons get too close » In mobile screens, buttons get too close
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +Needs merge request, +Needs reroll

The patches are for Drupal core.

immaculatexavier made their first commit to this issue’s fork.

immaculatexavier opened merge request !153

immaculatexavier’s picture

immaculatexavier commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Issue tags: -Needs merge request, -Needs reroll
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 70251da45e8231e5d94ad7e29686e9ab83f3a558.png15.92 KB

screenshot

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

  • avpaderno committed 8f66e1db on 2.0.x 
    Issue #3201325: In mobile screens, buttons get too close
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.