Make Upgrade Status logic make sense on Drupal 9

+++ b/src/DeprecationAnalyzer.php
@@ -574,7 +568,7 @@ final class DeprecationAnalyzer {
-    elseif (preg_match('!Deprecated (in|as of) [Dd]rupal[ :](8.\d)!', $error, $version_found)) {
+    elseif (preg_match('!Deprecated (in|as of) [Dd]rupal[ :](\d.\d)!', $error, $version_found)) {

I think it could use 10.x compatible preg (I mean \d+.\d)

+++ b/src/DeprecationAnalyzer.php
@@ -589,7 +583,7 @@ final class DeprecationAnalyzer {
-        if (version_compare($version, self::CORE_MINOR_OLDEST_SUPPORTED) <= 0) {
+        if (version_compare($version, ProjectCollector::getOldestSupportedMinor()) <= 0) {

+++ b/src/ProjectCollector.php
@@ -512,4 +512,30 @@ class ProjectCollector {
+    switch ($major) {
+      case 8:
+        return '8.9';
+      case 9:
+        return '9.0';

I think here should be default because otherwise condition will use NULL and could lead to false positives

+++ b/src/ProjectCollector.php
@@ -512,4 +512,30 @@ class ProjectCollector {
+   * @return string
+   *   Oldest supported core version number.

Then at least it should declare that for 10 core it will return NULL instead of string which expected as second argument for version_compare and will bring issues for php 8

Here's a small fix for UI using new method and fix to return empty string instead of null

Used to run on custom project and one of modules showed warning but probably it's unrelated because it used to fail before

Internal error: Interface PHPUnit\Framework\Test does not exist Run PHPStan with --debug option and post the stack trace to: https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

Debug option brings
PHP Warning: file_get_contents(): Filename cannot be empty in /var/www/html/web/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit8/ClassWriter.php on line 43 Warning: file_get_contents(): Filename cannot be empty in /var/www/html/web/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit8/ClassWriter.php on line 43 PHP Fatal error: Uncaught ReflectionException: Interface PHPUnit\Framework\Test does not exist in /var/www/html/vendor/mglaman/phpstan-drupal/src/Rules/Drupal/GlobalDrupalDependencyInjectionRule.php:50 Stack trace: #0 /var/www/html/vendor/mglaman/phpstan-drupal/src/Rules/Drupal/GlobalDrupalDependencyInjectionRule.php(50): ReflectionClass->implementsInterface() #1 phar:///var/www/html/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/FileAnalyser.php(69): PHPStan\Rules\Drupal\GlobalDrupalDependencyInjectionRule->processNode() #2 phar:///var/www/html/vendor/phpstan/phpstan/phpstan.phar/src/Node/ClassStatementsGatherer.php(91): PHPStan\Analyser\FileAnalyser->PHPStan\Analyser\{closure}() #3 phar:///var/www/html/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(388): PHPStan\Node\ClassStatementsGatherer->__invoke() #4 phar:///var/www/html/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(1762): PHPStan\Analyser\NodeScopeResolver::PHPStan\Analyser\{closure}() #5 phar:///var/www/html/vendor/p in /var/www/html/vendor/mglaman/phpstan-drupal/src/Rules/Drupal/GlobalDrupalDependencyInjectionRule.php on line 50 Fatal error: Uncaught ReflectionException: Interface PHPUnit\Framework\Test does not exist in /var/www/html/vendor/mglaman/phpstan-drupal/src/Rules/Drupal/GlobalDrupalDependencyInjectionRule.php:50 Stack trace: #0 /var/www/html/vendor/mglaman/phpstan-drupal/src/Rules/Drupal/GlobalDrupalDependencyInjectionRule.php(50): ReflectionClass->implementsInterface() #1 phar:///var/www/html/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/FileAnalyser.php(69): PHPStan\Rules\Drupal\GlobalDrupalDependencyInjectionRule->processNode() #2 phar:///var/www/html/vendor/phpstan/phpstan/phpstan.phar/src/Node/ClassStatementsGatherer.php(91): PHPStan\Analyser\FileAnalyser->PHPStan\Analyser\{closure}() #3 phar:///var/www/html/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(388): PHPStan\Node\ClassStatementsGatherer->__invoke() #4 phar:///var/www/html/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(1762): PHPStan\Analyser\NodeScopeResolver::PHPStan\Analyser\{closure}() #5 phar:///var/www/html/vendor/p in /var/www/html/vendor/mglaman/phpstan-drupal/src/Rules/Drupal/GlobalDrupalDependencyInjectionRule.php on line 50

After installing phpunit/phpunit I'm getting

PHPStan command failed:

/var/www/html/vendor/bin/phpstan analyse --debug --error-format=json -c /tmp/upgrade_status/deprecation_testing.neon /var/www/html/web/modules/custom/custom_menu 2> /tmp/upgrade_status/phpstan_error_output

Command output:

/var/www/html/web/modules/custom/custom_menu/custom_menu.install/var/www/html/web/modules/custom/custom_menu/src/Plugin/Menu/CurrentNodeMenuLink.php{"totals":{"errors":0,"file_errors":0},"files":[],"errors":[]}