Closed (fixed)
Project:
GatherContent
Version:
8.x-5.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Mar 2021 at 13:07 UTC
Updated:
26 Mar 2021 at 10:24 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
scott_euser commentedComment #3
gdeni commentedThank you for reporting the issue! I think it would be better to add an extra condition to the else section to check the field type instead of removing it.
If we remove the else section, it will be possible to map single value Drupal fields with repeatable GatherContent fields, that may cause errors or unexpected behaviours.
I would rather check if the field is a text field, as currently only text fields can be repeatable in GatherContent. This way, checkbox fields (and all other non-text fields) could be mapped as before, but text fields only with the same cardinality.
Patch is attached, do you think this could work?
Comment #4
scott_euser commentedThat looks good to me, thanks!
Comment #6
gdeni commentedThanks! Then, I'm making a new release that contains the bug fixes you reported.
Comment #7
gdeni commented