Summary element in vertical tabs are hidden

#2 Please review the patch

Hi, I've tested the patch on 9.1.x-dev and is applied cleanly. It fixes the tab hidden issue properly.

Hereby attaching the screenshots below,

Sample from Seven theme before patch applying,

Before patch on Claro theme,

After patch on Claro theme,

The steps followed are the same as mentioned in the description of the issue. I think it can be moved to RTBC.

So RTBC+1.

After patch #2, claro-details__summary--vertical-tabs-item title is visible.

Adding after patch screenshot for reference.

Moving to RTBC.

Don't know why the tests failed. Reran the tests and tested the patch. Works alright. RTBC + 1

Verified and tested patch #2.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto: Appearance -> Apply Claro theme
# Goto: Extend -> Click on Install New Module -> https://www.drupal.org/project/node_title_ps
# Goto: /admin/structure/types/manage/article
# See element is missing

Expected Results:
# Summary element in vertical tabs should not be hidden.

Actual Results:
# Summary elements in vertical tabs are hidden.

Please refer attached screenshots for the same.
Looks good to me.
Can be a move to RTBC.

Discussed with @lauriii. It'd be good to understand why this is happening. Perhaps there is a better workaround available. Also we can test this using a WebDriverTestBase test and asserting on visibility.

Applied patch #2 working fine
Thanks for the patch
for ref sharing screenshot ...

I can't reproduce this issue against Drupal 9.3.x-dev or 9.4.x-dev. On my side summary is not hidden by default without any patch

This still has the Needs tests tag, which was added in #9 and has not yet been addressed. Changing back to Needs Work. I have updated the "Remaining Tasks" section of the IS to call out the need to tests.

I thought I'd write a quick test, but it turns out I couldn't reproduce this manually on 9.3.x, which matches the comment from #11. I didn't even have to clear cache. I followed the steps to reproduce in the IS.

I'm going to close this as Cannot Reproduce.

Please re-open with updated steps to reproduce if anyone is finding that this is still an issue.

I did a little more research and I was a little too hasty with setting this to Cannot Reproduce. It's better classified as Outdated.

This issue got fixed as a side-effect of another issue: #3177415: Vertical Tabs CSS classes applying to non-vertical tab detail element groups

I reverted that fix locally and I was able to reproduce following the steps in the IS. So confidently changing to Outdated.

Thanks all!

Edit: I should note that the fix from that issue I referenced above was completely reworked by another recent issue: #3219340: Vertical tabs with #parents are broken in Claro. So technically I reverted both of these fixes in order to reproduce this issue with node_title_ps.