In css/acquia_connector.icons.css there are references to check.svg and error.svg files:

.toolbar-bar .acquia-inactive-subscription:before {
  background-image: url('../images/error.svg');
}

.toolbar-bar .acquia-active-subscription:before {
  background-image: url('../images/check.svg');
}

However neither of these exist in the modules /images/ folder.

This affects both 2.x and 3.x.

CommentFileSizeAuthor
#5 check-svg-and-error-svg-not-found-3200283-5.patch1.3 KBpavithra.raman
#4 check-error-icons-missing-3200283-4.patch596 bytessker101

Issue fork acquia_connector-3200283

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ThomWilhelm created an issue. See original summary.

siliconandincense’s picture

siliconandincense commented

Just popping here to say here too! :)

thomwilhelm’s picture

thomwilhelm commented
Title: check.svg not found » check.svg and error.svg not found
Issue summary: View changes
sker101’s picture

sker101 commented
StatusFileSize
new check-error-icons-missing-3200283-4.patch596 bytes

The icon styling was updated from this commit

Here's a patch that reuse the previous "check" and "error" icons from core.
I guess we could use this patch until the module developers upload the correct icon files.

Tested on 3.x

pavithra.raman’s picture

pavithra.raman commented
StatusFileSize
new check-svg-and-error-svg-not-found-3200283-5.patch1.3 KB

Or alternatively add those svgs back in the module. Making it independent of any image changes in core.

Not sure if this affects and backend tracking or Acquia Cloud monitoring, but it affects administration experience as the browser keeps the page on 'loading' state until it finds and loads these assets.

wells’s picture

wells
he/him/his
Primary language English
Location Seattle, WA
commented
Status: Active » Reviewed & tested by the community

It seems like the intention of the commit @sker101 pointed out was to bring the images in to the module. So +1 and RTBC for #5.

japerry’s picture

japerry
Location KOMK
commented
Version: 8.x-2.0-rc4 » 3.x-dev
Status: Reviewed & tested by the community » Fixed

Ahh shoot this was fixed in #2954548: Broken image - check.svg but didn't bring those icons to 3.x

Fixed.

japerry’s picture

japerry
Location KOMK
commented

Also, FYI we aren't fixing them in 2.x. Upgrade to 3.x branch. No reason to be using 2.x anymore!

nickmaine’s picture

nickmaine commented

I see the code was updated on 3/30. Is this really fixed? I tried 3.0 and 3.x-dev and I get same 2 messages in the logs.

1. page not found /modules/contrib/acquia_connector/images/check.svg

2. Then the 404 triggers Drupal\Core\ParamConverter\ParamNotConvertedException: The "node" parameter was not converted for the path "/node/{node}" (route name: "entity.node.canonical") in Drupal\Core\ParamConverter\ParamConverterManager->convert() (line 104 of /var/www/docroot/core/lib/Drupal/Core/ParamConverter/ParamConverterManager.php).

The referrer is /modules/contrib/acquia_connector/css/acquia_connector.icons.css?qqwnc3

check.svg isn't in the images directory.

thomwilhelm’s picture

thomwilhelm commented
Status: Fixed » Needs work

I don't see the images in the 3.x-dev branch either. Re-opening.

kuldeep_mehra27 made their first commit to this issue’s fork.

kuldeep_mehra27 opened merge request !4

japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Fixed

ahh i see it, we had it in our internal repository. It should look better now. And the commit from d.o should show it too here!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.