Closed (fixed)
Project:
Block Content Machine Name
Version:
8.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
22 Feb 2021 at 07:56 UTC
Updated:
14 Oct 2021 at 13:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
kvantstudio commentedComment #4
kiwimind commentedWhile this patch looks good, it's unable to be tested the way that the patches and composer updates work.
Code is pulled and dependencies met prior to patches being applied, so each time composer is run, the code is pulled with version 1.0, which then fails, stating dependencies.
Worth getting this in to avoid dependency hell. In order to make this change locally, I've had to move this module into custom (rather than contrib) and update this manually.
For such a small change, happy to mark as RTBC. Thank you.
Comment #5
samantharaut commentedI also tried to apply this patch and ran into the same issue that kiwimind pointed out. We use this module across many of our sites, and are currently updating for Drupal 9 compatibility. Since the current patch solution is run after the dependency check, the following error persists:
drupal/block_content_machine_name 1.6.0 requires drupal/machine_name_widget ^1.0 -> found drupal/machine_name_widget[1.0.0-alpha1, 1.0.0] but it conflicts with your root composer.json require (^2.0@alpha).Cutting a new release with the patch fix rolled in would fix this and would be a big help. Thank you!
Comment #6
tars16 commentedConfirming we have the same problem with the versioning as samantharuat. I ended up forking and adding it to my composer file instead.
Comment #8
miteshmapComment #12
miteshmap