Problem/Motivation

Dependency "drupal/machine_name_widget": "^1.0" not compatible with Drupal 9

CommentFileSizeAuthor
#2 3199593-1.patch296 byteskvantstudio
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

kvantstudio created an issue. See original summary.

kvantstudio’s picture

StatusFileSize
new296 bytes

miteshmap made their first commit to this issue’s fork.

kiwimind’s picture

Status: Active » Reviewed & tested by the community

While this patch looks good, it's unable to be tested the way that the patches and composer updates work.

Code is pulled and dependencies met prior to patches being applied, so each time composer is run, the code is pulled with version 1.0, which then fails, stating dependencies.

Worth getting this in to avoid dependency hell. In order to make this change locally, I've had to move this module into custom (rather than contrib) and update this manually.

For such a small change, happy to mark as RTBC. Thank you.

samantharaut’s picture

I also tried to apply this patch and ran into the same issue that kiwimind pointed out. We use this module across many of our sites, and are currently updating for Drupal 9 compatibility. Since the current patch solution is run after the dependency check, the following error persists:

drupal/block_content_machine_name 1.6.0 requires drupal/machine_name_widget ^1.0 -> found drupal/machine_name_widget[1.0.0-alpha1, 1.0.0] but it conflicts with your root composer.json require (^2.0@alpha).

Cutting a new release with the patch fix rolled in would fix this and would be a big help. Thank you!

tars16’s picture

Confirming we have the same problem with the versioning as samantharuat. I ended up forking and adding it to my composer file instead.

miteshmap’s picture

Version: 8.x-1.6 » 8.x-2.x-dev

  • progzy committed bd2f616 on 8.x-2.x
    Issue #3199593 - Set drupal/machine_name_widget required version to '^2....

miteshmap credited progzy.

miteshmap’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.