Problem/Motivation

#3001660: Fix Umami's responsive layout styles introduced a new css file to umami.libraries.yml:

css/components/regions/page-title/page-title.css: {}

However, this file does not exist.

Steps to reproduce

  1. Install Umami
  2. Disable CSS aggregation
  3. Note the 404 in the Network tab in the browser development tools: core/profiles/demo_umami/themes/umami/css/components/regions/page-title/page-title.css

Proposed resolution

Remove css/components/regions/page-title/page-title.css: {} from umami.libraries.yml

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#4 umami-includes-non-existing-file-3199284-4.patch701 bytesindrajithkb

Comments

idebr created an issue. See original summary.

markconroy’s picture

markconroy commented

Thanks for posting this issue.

I'm not sure how that happened. We do have a page-title.css file, but it's in the /blocks directory of the theme, not the /regions directory.

https://git.drupalcode.org/project/drupal/-/blob/9.2.x/core/profiles/dem...

indrajithkb’s picture

indrajithkb commented
Assigned: Unassigned » indrajithkb
indrajithkb’s picture

indrajithkb commented
Assigned: indrajithkb » Unassigned
Status: Active » Needs review
StatusFileSize
new umami-includes-non-existing-file-3199284-4.patch701 bytes

Hi, I have removed the css/components/regions/page-title/page-title.css: {} from umami.libraries.yml. Please review the patch.

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented

Thank you @Indrajith KB for the patch.

I think the patch should remove the current page-title.css reference from umami.libraries.yml,
and then add the correct location of the file - css/components/blocks/page-title/page-title.css

You did the removal part in #4.
Can you please add the correct location of the file?

indrajithkb’s picture

indrajithkb commented

Hi @shaal , "css/components/blocks/page-title/page-title.css" this location already exists in the umami.libraries.yml file.

gauravvvv’s picture

gauravvvv commented

Yes, css/components/blocks/page-title/page-title.css: {} this file path is already present in umami.libraries.yml file.

I think patch #4 is good to go.

gauravvvv’s picture

gauravvvv commented
Status: Needs review » Reviewed & tested by the community
shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented

Thank you, I forgot to change the status to RTBC :)

  • larowlan committed 0bbcb5d on 9.2.x 
    Issue #3199284 by Indrajith KB, markconroy: Umami includes non-existing...

  • larowlan committed 95fa7d3 on 9.1.x 
    Issue #3199284 by Indrajith KB, markconroy: Umami includes non-existing...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: +Bug Smash Initiative

Committed 0bbcb5d and pushed to 9.2.x. Thanks!

Cherry-picked to 9.1.x as the risk of disruption is low

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.