Problem/Motivation

Appears this error
"The 'core_version_requirement' constraint (9.1.4) requires the 'core' key not be set in modules/contrib/memcache/tests/modules/memcache_test/memcache_test.info.yml"

Steps to reproduce

Run drush cr

Proposed resolution

Remove core: 8.x from the file memcache.info.yml
Remove core: 8.x from the file memcache_test.info.yml and replace it with core_version_requirement: ^8 || ^9

CommentFileSizeAuthor
#20 3198531-20.patch6.87 KBn4r3n
#18 interdiff_13-18.txt5.33 KBn4r3n
#18 3198531-18.patch7.32 KBn4r3n
#13 3198531-13.patch1.99 KBgaurav.kapoor
#11 drupal-9-compatibility-issue-3198531-11.patch508 byteskriboogh
#10 drupal-9-compatibility-issue-3198531-9.patch461 byteskriboogh
#5 drupal-9-compatibility-issue-3198531-5.patch855 bytesyousefanbar
#2 drupal-9-compatibility-issue-3198531-2.patch1.09 KByousefanbar

Issue fork memcache-3198531

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

YousefAnbar created an issue. See original summary.

yousefanbar’s picture

yousefanbar commented
StatusFileSize
new drupal-9-compatibility-issue-3198531-2.patch1.09 KB
yousefanbar’s picture

yousefanbar commented
Issue summary: View changes
yousefanbar’s picture

yousefanbar commented
Version: 8.x-2.x-dev » 8.x-2.0
yousefanbar’s picture

yousefanbar commented
StatusFileSize
new drupal-9-compatibility-issue-3198531-5.patch855 bytes
yousefanbar’s picture

yousefanbar commented
Issue summary: View changes
japerry’s picture

japerry
Location KOMK
commented
Status: Active » Closed (outdated)

This was fixed a long time ago.

kriboogh’s picture

kriboogh commented

Nope it's still there (i'm on 2.3)

kriboogh’s picture

kriboogh commented
Status: Closed (outdated) » Needs review
kriboogh’s picture

kriboogh commented
StatusFileSize
new drupal-9-compatibility-issue-3198531-9.patch461 bytes

The main info yml file is updated, but the test still has the problem.

kriboogh’s picture

kriboogh commented
StatusFileSize
new drupal-9-compatibility-issue-3198531-11.patch508 bytes

Attached is a patch for 2.3

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Needs work

There are still a few deprecation issues shown by Drupal Check which will have to be resolved to make module compatible with D9.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs work » Needs review
StatusFileSize
new 3198531-13.patch1.99 KB

Removed the code marked deprecated in Symfony 4.3 as well as retained adding key 'core_version_requirement: ^8 || ^9' in memcache_test.info.yml.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Looks good!

hswong3i made their first commit to this issue’s fork.

hswong3i opened merge request !4

hswong3i’s picture

hswong3i commented
Version: 8.x-2.0 » 8.x-2.x-dev

MR created from #13

n4r3n’s picture

n4r3n
he/him
Location Goa
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3198531-18.patch7.32 KB
new interdiff_13-18.txt5.33 KB

There were few more deprecations:

 ------ ----------------------------------------------------------------------
  Line   src/MemcacheBackend.php
 ------ ----------------------------------------------------------------------
  183    Call to deprecated constant REQUEST_TIME: Deprecated in drupal:8.3.0
         and is removed from drupal:10.0.0. Use
         \Drupal::time()->getRequestTime();
  365    Call to deprecated constant REQUEST_TIME: Deprecated in drupal:8.3.0
         and is removed from drupal:10.0.0. Use
         \Drupal::time()->getRequestTime();
 ------ ----------------------------------------------------------------------

Re-rolling patch #13 along with interdiff.

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Needs work

Per: https://www.drupal.org/node/3070687 -- test modules don't need (and shouldn't have) the core_version_requirement key in them.

We need to test the Request time piece a bit to ensure it works. Last time this was committed it caused errors because the container couldn't be initialized before getting the request time.

n4r3n’s picture

n4r3n
he/him
Location Goa
commented
Status: Needs work » Needs review
StatusFileSize
new 3198531-20.patch6.87 KB

Removed core_version_requirement key from test module and updated the patch.
I tried mocking getRequestTime() in local, seems working.

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Closed (duplicate)

This patch is a duplicate of the D10 issue #3288536: Automated Drupal 10 compatibility fixes