Problem/Motivation

Upon upgrade to version 2.0.1, the container and gutter selectors are rendered, but not working (not clickable).

Steps to reproduce

Using Bootstrap 3, Bootstrap Styles 1.0.3.
If applying the classes blb_container_type and blb_gutter_type in BootstrapLayout php Line 343 and Line 363 is commented out, the input radios are shown, the options can be selected and the layout is modified as expected.
When using this module with Bootstrap 4 the container and gutters selectors work as expected.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 after_patch.png13.4 KBmadalozzo
#5 bootstrap-3-styles-3198421-5.patch3.81 KBmadalozzo
container_type_no_link.png20.34 KBjordik

Comments

JordiK created an issue. See original summary.

jordik’s picture

jordik commented
Issue summary: View changes
aaronchristian’s picture

aaronchristian commented

Thanks @JordiK,

We'll slot in some time to review this and see if we can reproduce this one.

jordik’s picture

jordik commented

Thank you Aaron! Tell me if you need further info in order to reproduce this.

madalozzo’s picture

madalozzo commented
StatusFileSize
new bootstrap-3-styles-3198421-5.patch3.81 KB
new after_patch.png13.4 KB

Hello, I was able to replicate this one. I have investigated it and I believe I have found what's going on here.

This is happening because the Bootstrap 3 theme has a preprocess on src/Plugin/Preprocess/FormElement.php that places the input inside the label, so the css on Bootstrap Styles is not applying the active background. The inputs are actually working fine, it's just that they seem unresponsive because the background stays the same.

I have created a patch for it, but the changes to solve this are on the Bootstrap Styles module, so I'm not sure on how to proceed, as this is my first contribution.

c.altosax’s picture

c.altosax commented

Someone posted a similar issue under under the Bootstrap Styles module. Maybe that would be a better place to discuss this?

freddy rodriguez’s picture

freddy rodriguez
Location Bogotá
commented

Mandalozzo:

https://www.drupal.org/community/contributor-guide/find-a-task

drupgirl’s picture

drupgirl commented

Thanks this fixed some of the issues. Very helpful.

I patched the mod with curl and put it in the custom directory. The Backgroud tab Image section is still pretty messed up, but lots of improvement. Thank you!

justclint’s picture

justclint commented

thanks @Madalozzo for pointing out the src/Plugin/Preprocess/FormElement.php

I was able to get this working by copying that into my subtheme and just commenting out the part that moves the checkboxes and radios.

Had to refactor some of our checkbox and radio styles but very minimal.

This seems to be the easiest way to get it working with https://www.drupal.org/project/bootstrap

mahmoud-zayed’s picture

mahmoud-zayed commented
Project: Bootstrap Layout Builder » Bootstrap Styles
Version: 2.0.1 » 2.0.x-dev
Status: Active » Needs work

I have tested the patch, container still not working.

aitala’s picture

aitala commented

Same issue with the container selector not working.

Eric