Remove dompdf/dompdf from composer.json require [#3198071]

Problem/Motivation

This module supports multiple PDF rendering engines. Therefore, dompdf should not be listed as required in the composer.json file.

"require": {
    "dompdf/dompdf": "~0.8.0"
  },

Steps to reproduce

Proposed resolution

Move dompdf to 'suggest' section so that it is not required. Furthermore, change the version requirement to "^0.8.0" so that newer versions can be used, e.g., to get latest fixes and PHP8 compatibility.

Comment	File	Size	Author
#2	entity_print-remove_dompdf_req-3198071-2.patch	308 bytes	julien.sibi

Issue fork entity_print-3198071

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3198071-remove-dompdfdompdf-from compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

11 February 2021 at 23:45

lunk rat created an issue. See original summary.

Comment #2

julien.sibi

French

commented 22 February 2021 at 13:05

Status	File	Size
new	entity_print-remove_dompdf_req-3198071-2.patch	308 bytes

Hi,

here is a small patch to remove dompdf requirement from composer.json file but composer checks repository version.. so waiting it to be potentially commited, you can use this in your composer.json project require :
"dompdf/dompdf":"v1.0.2 as 0.8.6"

Julien

Comment #3

ey commented 25 April 2022 at 14:34

Status:

Active

» Needs review

Comment #4

27 June 2022 at 20:21

dan.d made their first commit to this issue’s fork.

Comment #5

neograph734

he/him

Netherlands

commented 1 July 2022 at 15:59

Status:

Needs review

» Needs work

The provided patch does not move dompdf to 'suggest' as proposed in the issue summary.

Also dompdf is the only PDF generation solution that does not depend on binaries to be installed. I personally like it being automatically installed because this is the most out-of-the-box experience this module can have.

Comment #6

welly commented 20 July 2022 at 11:12

There is an issue with this being a requirement in that the version of dompdf being installed is old and out of date, and also means other modules that have a dependency on dompdf are not able to be updated as the dompdf version is being locked by this module. I would back the suggestion to move dompdf to the suggest section.

Edit Have seen that the latest version of entity_print does support the latest dompdf verson so this should be fine. But it could still be an issue when different modules have different dependency version requirements.