CKEditor5 meeting 2021-01-28 [#3197608]

Meeting Details

This CKEditor5 in Drupal core meeting is held biweekly on Thursdays at 15:30 UTC (10:30am ET)
in drupal.slack.com in the #ckeditor5 channel.

Meeting notes

0️⃣ Hi and welcome to the biweekly CKEditor5 in Drupal meeting!

This meeting happens every other Thursday at 15:30 UTCPlease say hi if you're around (include your d.o for issue credit)!
Feel free to post in the threads or start your own
You may also join the meeting later and participate asynchronously!

lauriii	hey! :wave:
Gábor Hojtsy (he/him)	heay
Wesley Klop	heyo, I’m w3ssl3y on d.o
markie	hey there.. markie on d.o.. Damien highlighted this initiative on his weekly contrib meeting..
gapple	:v:
hansa11	Hi :wave:

1️⃣ From prototype to contrib

zrpnr	Last time we discussed that the work on this project would be moved from the core issue to a contrib project. There is now working code at https://www.drupal.org/project/ckeditor5 Please open any issues there, there are also several feature requests that need review and are (hopefully) almost ready to merge.
lauriii	I was trying to review #3194650: Support media elements and browse media library but I got some errors in console
lauriii	I tried to set up the DLL build tools to be able to do some debugging but wasn’t able to figure out how to do that :smile:
Gábor Hojtsy (he/him)	posted https://twitter.com/DropIsMoving/status/1354821022327873539 for more visibility
Gábor Hojtsy (he/him)	RTs welcome

2️⃣ DLL builds

zrpnr	The contrib project is using the DLL builds - more info at https://github.com/ckeditor/ckeditor5/issues/8395 This has been working really well so far, and enables us to write javascript plugins that compile in a way that can be added using Drupal's library system.Hopefully this gets into an official release soon! Looks like there has been some activity a few days ago on the github project. does anyone know if there are any updates, or anything we can do to help?
lauriii	I was looking at some work related to this. It would be useful for someone not so familiar with the code base like me to have a bit more docs on the different DLL plugins and where their source code is located, as well as how to set up the development environment :smile:
Gábor Hojtsy (he/him)	@Piotr Koszuliński do you know when this is planned to be integrated to the main branch?
lauriii	I wrote down some of the things I learned from @zrpnr #3195188: Provide documentation on how to set up a development environent

3️⃣ Plugin repos

zrpnr

I have setup some projects for the js plugins, for example: https://github.com/zrpnr/ckeditor5-drupal-image
https://github.com/zrpnr/ckeditor5-drupal-media
This has been nice DX since I can use modern js, include whatever packages I need etc, and then just output minified js to include with the Drupal plugin.
Will this be controversial when ckeditor5 goes into core? I've heard some rumors about d.o. supporting npm, as well as the new "component" project type #2474007: Add a “General” project type to Drupal.org
Also would there need to be any requirements for the dependent packages in a js plugin?
Or other reasons this is good/bad?

4️⃣ Allowed HTML tags configuration

lauriii	The current implementation essentially forces users to set a certain configuration of allowed HTML tags and attributes based on the CKEditor plugins available in the build. I’m wondering if we should move this for just text that shows available HTML elements for now?
lauriii	On top of that we could open separate issue for discussing what to do in the long term
lauriii	This is one of the first things people see when they try the module out and it must be very confusing to someone with no context
lauriii	another reason this is a bit broken is that if you install or uninstall a module (or change to PR) that adds a plugin, you will have to go adjust the allowed elements
zrpnr	adding plugin / toolbar config will help with the current situation- since if you just enabled media for example you wouldn't have the option to embed without first going to the editor config page
zrpnr	and then you'd get the validation warning if it wasn't one of the allowed html types

5️⃣ Lessons learned from CKE4

Taran2L	I was also wandering is there a plan to (maybe) improve certain things compared to CKE4 (in general, not having a particular ideas)
zrpnr	one thing I'm hoping will improve is making it easier to extend and add features through contrib.

Participants:

lauriii, Gábor Hojtsy, Wesley Klop (w3ssl3y), markie, gapple, hansa11, zrpnr, Taran2L