file uploads file when memcache statistics are written to page footer - easy fix [#319697]

When "memcache admin" is enabled, and the "show memcache statistics at the bottom of each page" option is selected on admin/settings/memcache, file uploads fail.

The fix is easy, just replace the following line in memcache_admin_init():

if (($user->uid == 0) || strstr($_SERVER['PHP_SELF'], 'update.php') || strstr($_GET['q'], 'autocomplete')) {

with this (heavily borrowing from devel module)

if (($user->uid == 0) || strstr($_SERVER['PHP_SELF'], 'update.php') || strstr($_GET['q'], 'autocomplete') || $_GET['q'] == 'admin/content/node-settings/rebuild' || $_GET['q'] == 'upload/js' || substr($_GET['q'], 0, strlen('system/files')) == 'system/files') {

-mike

Comment	File	Size	Author
#2	memcache_admin.module.319697.patch	907 bytes	jaydub

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Jeremy CreditAttribution: Jeremy commented 30 October 2008 at 19:31

Status:

Active

» Needs review

Can someone test this and confirm it solves the problem? (Attaching a real patch would certainly help...)

Comment #2

jaydub CreditAttribution: jaydub commented 30 April 2009 at 17:35

File	Size
memcache_admin.module.319697.patch	907 bytes

Comment #3

ambo CreditAttribution: ambo commented 11 September 2009 at 09:32

Hi,

i run into this issue on a drupal installation using imagecache. for some reason imagecache is redirecting to itsself if a picture is rebuild with imagemagick or gd-lib. in this case drupal has not run the full bootstrap so no theming is available. memcache admin still wants so theme the memcache stats, and therefor has to implement theming functions. but in php's shutdown function working directory is set to / so no relative requires or includes are possible.

in memcache.admin on line 223 you still check for soe content-types which don't like text outputs, maybe it is usefull to check some more (dunno what header exists while processing images) here?

Comment #4

quicksketch

he/him

CreditAttribution: quicksketch commented 10 August 2010 at 19:34

Status:

Needs review

» Needs work

Memcache is responsible for many instances of file uploads breaking in the FileField queue, see #297035: HTTP error 0 . Rather than checking certain paths however, a more reliable method would be checking headers for any type other than "text/html", as Devel module currently does.

Comment #5

Exploratus CreditAttribution: Exploratus commented 15 October 2010 at 19:48

Version:

5.x-1.8

» 6.x-1.6

I just installed memache, and when i try to upload a file i get AHAH problem and it breaks - Version 6.x - 1.6. Any solutions?

Comment #6

Jeremy CreditAttribution: Jeremy commented 15 October 2010 at 19:54

Status:

Needs work

» Postponed (maintainer needs more info)

Are you able to duplicate with the latest -dev snapshot?

Comment #7

Fabianx CreditAttribution: Fabianx commented 30 March 2011 at 04:37

Version:	6.x-1.6	» 6.x-1.8
Assigned:	Unassigned	» Fabianx

Problem is still active in 6.x-1.8.

I'll fix this soon as it would be nice to have memcache admin not break all upload fields ...

Comment #8

catch

he/him

English

CreditAttribution: catch commented 19 April 2011 at 08:40

Assigned:	Fabianx	» Unassigned
Status:	Postponed (maintainer needs more info)	» Needs work

Re-opening this. #372810: Lots of failed include_once errors is duplicate.

Comment #9

catch

he/him

English

CreditAttribution: catch commented 19 April 2011 at 09:52

Component:	Code	» memcache_admin
Priority:	Normal	» Major

Comment #10

Jeremy CreditAttribution: Jeremy commented 5 May 2011 at 15:43

Status:

Needs work

» Fixed

Duplicated, and patch applied (with some minor changes). Confirmed that file uploads were broken before the patch, and work after the patch (using the core upload module).
http://drupalcode.org/project/memcache.git/commitdiff/566d3e9