I installed the module - but now I can't save menu item translations any more. How can this be fixed?

CommentFileSizeAuthor
#22 menu-attributes-translation-3196822-22.patch7.05 KBalesbencina

Issue fork menu_link_attributes-3196822

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vistree created an issue. See original summary.

yannickoo’s picture

yannickoo
Location Berlin
commented
Status: Active » Postponed (maintainer needs more info)

Hey vistree, could you explain what "I can't save menu item translations any more" means? Do you see any errors displayed?

vistree’s picture

vistree commented
Issue summary: View changes
vistree’s picture

vistree commented
Issue summary: View changes

Steps to reproduce:

  • Install "menu link attributes"
  • Make sure to enable "Menu language" for your menu (e.g EN)
  • Create a menu item + set item language (e.g. EN) + add menu link attributes (e.g. "Container class" = "icon-search" + "class" = "menu-icon")
  • Save the menu item and try to add a translation.
  • Change "Menu link title" only
  • Save the translation

On screen error: Non-translatable fields can only be changed when updating the original language.
No error in watchdog!
No error in browser console

If I remove all menu link attributes, save the original menu language item - then I can add the menu item translation

vistree’s picture

vistree commented
Status: Postponed (maintainer needs more info) » Active
danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented

I'm not getting the issue with them breaking, but it appears the attributes aren't translatable. Any changes made to an attribute sync across all translations. Hopefully I'll have time to look into this.

vistree’s picture

vistree commented

Hi @DanielVeza,
I found, that the issue only occurs if option "Hide non translatable fields on translation forms" is enabled for "Custom menu link" on "/admin/config/regional/content-language".
Can you please enable this option and restest?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 8.x-1.1 » 8.x-1.x-dev
danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented

I've tried enabled and disabled, no luck. Any change to an attribute is propagated across all translations

nord102’s picture

nord102
he/him
Primary language English
commented

I can confirm that the issue is only occurring when disabling Hide non translatable fields on translation forms for Custom menu link as per #7

Although this is not the best solution, it is a workaround until we can get a proper solution in place.

Alex Bukach made their first commit to this issue’s fork.

Alex Bukach opened merge request !2

Alex Bukach opened merge request !3

Alex Bukach closed merge request !2

maxpah’s picture

maxpah
Primary language French
commented

Hello, thanks for the patch !
Working great on dev branch.
When do you plan to do a new stable release with this critical bug resolved ?

vistree’s picture

vistree commented

Hi @Alex, patch is working for me on DEV also!!

maxpah’s picture

maxpah
Primary language French
commented
Status: Active » Reviewed & tested by the community

jcnventura made their first commit to this issue’s fork.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

alesbencina’s picture

alesbencina commented
StatusFileSize
new menu-attributes-translation-3196822-22.patch7.05 KB

Adding a reroll patch for the latest version.
I briefly tested on the 8.x-1.2 and looks good.

Looking forward for a release!

alexrayu’s picture

alexrayu commented

Hello guys, still having this issue despite the patch having been 3 years ago. The workaround from #7 still works.

droprocker’s picture

droprocker commented

I can confirm that this issue still exists. Workaround from #7 is not a solution, since this is exactly what we do not want the form to behave.

jcnventura’s picture

jcnventura
Primary language English
commented

Please don't comment on a closed issue. Especially since #3479404: Menu link translations can not be created exists and may fix this issue.