Problem/Motivation

There is a second widget named 'Sentiment check'
https://www.digital.nsw.gov.au/transformation/goverment-technology-platf...

Proposed resolution

Add a block plugin for that

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

larowlan created an issue. See original summary.

larowlan’s picture

Status: Active » Reviewed & tested by the community
Anonymous’s picture

larowlan credited liton10.

larowlan credited mcaddy.

larowlan credited sime.

larowlan’s picture

  • larowlan committed 8835167 on 8.x-1.x
    Issue #3196695 by larowlan, liton10, mcaddy, sime, xtineroque, tapscolaM...
larowlan’s picture

Status: Reviewed & tested by the community » Fixed
mcaddz’s picture

I think the Sentiment check twig template should be vanilla, not opinionated.

i.e.

<div id=”testPlaceholder”></div>
<script type="text/javascript">
    window.onload = function(){
        quickFeed.init({
            placeholder:"testPlaceholder",
            label:"Do you like the website?",
            environment:'uat'.
sourceApplication: 'Your Project Name'
        });   
    };
</script>

This way customisations can be done in a separate module/theme. Also the 'placeHolder' value is optional and when it's not passed, the widget is floated right on the page.

This might be the desired approach for some agencies.

Also the Description field is not used anywhere in the JS snippet (above) so I feel this should be implemented elsewhere in a theme/separate module. CSS overrides would also live in the same place so the module is more generic.

I also wonder if we need consistent names for the blocks? I was searching for 'feedback' initially when placing the block which didn't bring up the One Gov block which might be confusing for others.

Suggested names for the blocks:

NSW feedback (Feedback assist)
NSW feedback (Sentiment check)

mcaddz’s picture

Will move the items identified in the comment above ^ to separate issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.