klaro.renderKlaro is not a function [#3195352]

Problem:

If I check the "Show automatically" box, the module JS throws the error: "Uncaught TypeError: klaro.renderKlaro is not a function
at HTMLDocument. (klaro.drupal.js?qnp0ti:24)"

Steps to reproduce:

Drupal 9.1.3: install, enable and configure the module, check the "Show automatically" box

Quick fix

I couldn't find any renderKlaro() Method in the klaro API.
If I changed the following in klaro.drupal.js, it seems to work as I want
I have never used klaro before, so I am not sure I am doing the right thing:

if (settings.klaro.autoShow) {
    klaro.renderKlaro(settings.klaro.config);
}

if (settings.klaro.autoShow && !klaro.getManager(settings.klaro.config).confirmed) {
    klaro.show(settings.klaro.config);
}

Comment	File	Size	Author
#8	klaro-support_for_0.7.x-3195352-8.patch	2.99 KB	Mirroar
#7	klaro-support_for_0.7.x-3195352-7.patch	2.56 KB	Mirroar

Comments

Comment #1

29 January 2021 at 11:37

flomar created an issue. See original summary.

Comment #2

flomar commented 29 January 2021 at 16:13

Issue summary:

View changes

Comment #3

flomar commented 29 January 2021 at 16:55

Issue summary:

View changes

Comment #4

joachim namyslo

German

Kulmbach 🇩🇪 🇪🇺

commented 29 April 2021 at 12:16

With this fix applyed klaro is visible once, again. But after clear cookies klaro is gone away, even if no cookie is set anymore. Also there is an error message for a php function in a different file. So this needs to be checked and fixed. Claro is unusable because of the java-Script error targeted here.

Comment #5

joachim namyslo

German

Kulmbach 🇩🇪 🇪🇺

commented 15 September 2021 at 06:03

Debugging this issue i came to the conclusion that klaro needs klaro 0.5.x to work correctly. If the verison number of the lib is higher currently there is the js error in the console mentioned in that issue So either this should be fixed by implementing 0.7.x or be mentioned more prominent in documentation not just in change lag

Comment #6

Mirroar commented 27 September 2021 at 11:26

Version 0.6.5 of the klaro library also works fine with the module currently.
I'm guessing starting with 0.7.0 renderKlaro was changed and renamed to render. Even fixing that in klaro.drupal.js you still get the message "Warning, your configuration file is outdated. Please change `apps` to `services`" in the console, so updating will take a little more work.

We should update the module so it is compatible with newer versions of the klaro library, or specify a supported version range in the readme and on the project hompage.

Comment #7

Mirroar commented 28 September 2021 at 10:01

Status:

Active

» Needs review

Status	File	Size
new	klaro-support_for_0.7.x-3195352-7.patch	2.56 KB

Here's a patch to get the module compatible with the 0.7.x set of releases for klaro. Ideally we also need to inform the user on update that they need to download a newer version of the klaro library. Will an update hook that outputs a message suffice?

Comment #8

Mirroar commented 27 October 2021 at 10:06

Status	File	Size
new	klaro-support_for_0.7.x-3195352-8.patch	2.99 KB

Here's a slightly updated patch that also moves the translation key "app" to "service". A cleaner version would probably rename the key within config forms, adjust the modules config schema, and include an update hook to move the existing data. But if you just need it working, this will do for now.