Problem/Motivation

When a theme defines a different color for visited links, this custom color can be seen in the toolbar on visited links as well.

Steps to reproduce

In a theme CSS file, define a color for visited anchors:

a:visited {
    color: red
}

Notice red links appearing in the toolbar for pages you have visited.

Observed behavior

Proposed resolution

Toolbar already defines the colors for all other states. The visited state can best be appended to the first group I think.

.toolbar-tray a {
  padding: 1em 1.3333em;
  cursor: pointer;
  text-decoration: none;
  color: #565656;
}
.toolbar-tray a:hover,
.toolbar-tray a:active,
.toolbar-tray a:focus,
.toolbar-tray a.is-active {
  text-decoration: underline;
  color: #000;
}

Remaining tasks

Update CSS to:

.toolbar-tray a,
.toolbar-tray a:visited, {
  padding: 1em 1.3333em;
  cursor: pointer;
  text-decoration: none;
  color: #565656;
}

User interface changes

Minor improvement; the toolbar is no longer affected by the theme.

API changes

None

Data model changes

None

Release notes snippet

None

CommentFileSizeAuthor
#27 After-patch-css.png25.33 KBsonam.chaturvedi
#27 After-patch#20.png161.39 KBsonam.chaturvedi
#27 before_patch#20.png157.21 KBsonam.chaturvedi
#22 Screenshot from 2021-10-27 14-17-05.png17.62 KBradheymkumar
#21 After--patch--pic.png27.27 KBvikashsoni
#21 Before--patch--pic.png29.41 KBvikashsoni
#20 3195033-different-colors-for-visited-links-toolbar-20.patch2.75 KBNeograph734
#19 3195033-different-colors-for-visited-links-toolbar-19.patch2.75 KBNeograph734
#18 interdiff-2-18.txt998 bytesimalabya
#18 3195033-different-colors-for-visited-links-toolbar-18.patch1.44 KBimalabya
#6 Screenshot 2021-03-08 at 12.28.23.png81.27 KBGauravvvv
#4 After--patch.jpg233.03 KBranjith_kumar_k_u
#4 Before--patch.jpg254.14 KBranjith_kumar_k_u
#3 Schermafbeelding 2021-01-28 111815.jpg28.04 KBNeograph734
#2 3195033-different-colors-for-visited-links-toolbar.patch574 bytesNeograph734
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Neograph734 created an issue. See original summary.

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 as a volunteer commented
Status: Active » Needs review
FileSize
3195033-different-colors-for-visited-links-toolbar.patch574 bytes
Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 as a volunteer commented
Issue summary: View changes
FileSize
Schermafbeelding 2021-01-28 111815.jpg28.04 KB
ranjith_kumar_k_u’s picture

ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commented
FileSize
Before--patch.jpg254.14 KB
After--patch.jpg233.03 KB

The patch works fine

Before patch
before patch

After patch
after patch
RTBC

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Considering the triviality of the change, I think that one RTBC should be enough.
Thanks for testing ranjith_kumar_k_u.

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commented
FileSize
Screenshot 2021-03-08 at 12.28.23.png81.27 KB

Patch #2, seems fine to me.
RTBC +1.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3195033-different-colors-for-visited-links-toolbar.patch, failed testing. View results

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 as a volunteer commented
Status: Needs work » Reviewed & tested by the community

That seems unrelated. Back to RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3195033-different-colors-for-visited-links-toolbar.patch, failed testing. View results

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 as a volunteer commented
Status: Needs work » Reviewed & tested by the community

And again an unrelated fail.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3195033-different-colors-for-visited-links-toolbar.patch, failed testing. View results

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 as a volunteer commented
Status: Needs work » Reviewed & tested by the community

Well...

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented

This time it was caused by #3207086: [HEAD BROKEN] Consistent failure in MonthDatePluginTest which was fixed.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3195033-different-colors-for-visited-links-toolbar.patch, failed testing. View results

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs work » Reviewed & tested by the community

Restoring status after HEAD was broken.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Needs work

This CSS is overridden in Stable and Stable 9, which many themes use as a base theme. This seems like a nice non-disruptive bug fix which we should do in Stable and Stable 9 too.

imalabya’s picture

imalabya
he/him
Primary language English
Location Bangalore
CreditAttribution: imalabya at Specbee for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3195033-different-colors-for-visited-links-toolbar-18.patch1.44 KB
interdiff-2-18.txt998 bytes

Added a patch for Stable and Stable9 themes.

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 as a volunteer commented
FileSize
3195033-different-colors-for-visited-links-toolbar-19.patch2.75 KB

Well, I just learned that the toolbar uses the admin theme instead of the page theme. During testing I could not get the red links to go away... Until I figured that Claro also defined them.

Fix includes Claro as well.

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 as a volunteer commented
FileSize
3195033-different-colors-for-visited-links-toolbar-20.patch2.75 KB

And now including the commas. Not sure why they not copied over...

vikashsoni’s picture

vikashsoni CreditAttribution: vikashsoni as a volunteer and at Zyxware Technologies commented
FileSize
Before--patch--pic.png29.41 KB
After--patch--pic.png27.27 KB

Applied patch working fine
for ref sharing screenshot

radheymkumar’s picture

radheymkumar CreditAttribution: radheymkumar commented
FileSize
Screenshot from 2021-10-27 14-17-05.png17.62 KB

Patch working fine
Thanks for the patch

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 as a volunteer commented

@vikashsoni and @radheymkumar, thanks for your reviews, but the attached screenshots do not help.

Before patch should be red letters and after patch the letters should be black. The pictures now show that the patch is making red letters!?

Could you please doublecheck? If all is good we can change to RTBC.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented

Removing credit for #22, adds a screenshot of the exact same thing provided in the previous comment is redundant and adds noise to the issue.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

sonam.chaturvedi’s picture

sonam.chaturvedi CreditAttribution: sonam.chaturvedi at Salsa Digital commented
Status: Needs review » Reviewed & tested by the community
FileSize
before_patch#20.png157.21 KB
After-patch#20.png161.39 KB
After-patch-css.png25.33 KB

Verified and tested patch #20 on 9.5.x-dev. Patch applied successfully.

Test Steps:
1. Login to drupal site
2. Visit various toolbar links
3. Inspect and Verify theme css is updated as below

.toolbar-tray a,
.toolbar-tray a:visited, {
  padding: 1em 1.3333em;
  cursor: pointer;
  text-decoration: none;
  color: #565656;
}

4. Now update theme css as below

a:visited {
    color: red
}

5. Check colors for visited does not bleed into the toolbar
6. Verify above steps for Claro theme as well

Test Results:
1. Theme css is updated as expected.
2. Even after adding "a:visited { color: red }" css > Color do not bleed. toolbar-tray css overrides the anchor link css for toolbar menus. Good
3. Content links and toolbar visited color works as expected for Claro theme.

Before patch:
bef patch 20

After patch:
after patch 20

after patch css

Moving to RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 75514e16b6 to 10.1.x and f550c1875d to 10.0.x. Thanks!
Committed 7d191e4 and pushed to 9.5.x. Thanks!

Removed credit for duplicate screenshots. Credited @sonam.chaturvedi because #27 was very explicit about steps taken.

  • alexpott committed 75514e1 on 10.1.x 
    Issue #3195033 by Neograph734, imalabya, sonam.chaturvedi,...

  • alexpott committed f550c18 on 10.0.x 
    Issue #3195033 by Neograph734, imalabya, sonam.chaturvedi,...

  • alexpott committed 7d191e4 on 9.5.x 
    Issue #3195033 by Neograph734, imalabya, sonam.chaturvedi,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.