The tests of Search API Solr fail on PHP 8:

ArgumentCountError: array_merge() does not accept unknown named parameters

/home/runner/work/search_api_solr/search_api_solr/drupal/modules/contrib/search_api/src/Plugin/search_api/processor/Highlight.php:283
CommentFileSizeAuthor
#4 search_api.patch861 bytesmkalkbrenner

Issue fork search_api-3194016

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mkalkbrenner created an issue. See original summary.

mkalkbrenner opened merge request !5

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

This change is very simple and should not cause the composer failure seen in the tests here. Not sure how to fix this either. It looks like search_api_autocomplete is not ready yet for d9, but it should be. It might be because the bot does `--prefer-stable`?
If that were the case, patches like #3193998 would not pass though. I don't know what is going on there :/

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Active » Needs review
StatusFileSize
new search_api.patch861 bytes
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

Looks like I found a bug in the test infrastructure. The uploaded patch gets tested without a composer issue, but the MR doesn't.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

The test failure on PHP8 is caused by the autocomplete module.
Can we quickly commit the patch to unblock the Search API contrib modules to get the PHP8 issues fixed on their side?
This would include search_api_autocomplete.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Fixed

Merged, thanks @mkalkbrenner (& @nick_vh for approval in slack ;))

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.