Hello all, it’s time for the weekly migration subsystem meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to here: TODO. See the parent issue for an idea of the typical agenda.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

benjifisher @mikelutz (he/him) @heddn @quietone @phenaproxima (he/him) @Gábor Hojtsy (he/him) @webchick @damienmckenna @benjifisher @alison @Joshua Turton (srjosh) @wimleers (he/him) @dinarcon @steinmb @Ginho @john.ouellet @Nick Dickinson Wilde @Seth Green

Core migration issues:

0️⃣ Who is here today? Did you learn something, or get encouragement from someone, working on a d.o issue?

quietone Vicki,. Yes, benjifisher continues to teach me patience and attention to detail.
benjifisher Benji: like Vicki, one of the co-maintainers of the migration subsystem. I appreciate Vicki's comment here: #2796755: [PP-1] Deprecate Migration::set()#comment-13959040 @benjifisher, good on you for complimenting yourself!(edited)
mikelutz (he/him) hi all (edited)
Matroskeen :wave: Ivan from Ukraine. I got a couple of RTBC’s from @quietone today, it is pretty encouraging :raised_hands:
dinarcon Hello everyone :wave:

1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.

quietone #2845340: migrate mapping & messages table names are truncated, can lead to incorrect mapping lookups
quietone #2456259: [META] Drupal 7 to Drupal 8 Migration path
quietone #3039240: Create a way to declare a plugin as deprecated
dinarcon It would be nice to have a way to disable hook execution during a migration. There is some work on https://www.drupal.org/sandbox/onkeltem/2828817 Either helping in promoting to a full project or bringing the functionality to core would be great.

2️⃣ Action items. To be added later.

benjifisher Looking at last week's action items, I think we have made progress on most of those issues, but I will copy them here so that we can keep track.
benjifisher Fixed: #3150733: Drupal 9 compatibility fixes for Commerce Migrate
benjifisher See 5️⃣ #3143486: Invalid migrations being ignored by the migrate process plugin: migration_lookup
benjifisher No progress (See 6️⃣): https://gitlab.com/drupalspoons/migrate_tools/-/issues/118 :disappointed: (edited)
benjifisher RTBC: #3189587: Add documentation for taxonomy terms source plugins
benjifisher Progress, currently NW: #3069776: SQL source plugins: allow defining conditions and join in migration yml
benjifisher Progress, currently NR: #3063856: Add ability to view migrate_message table data

3️⃣ Statistics

benjifisher Fixed since last week's meeting: 5 (not counting the issue for the meeting).
benjifisher RTBC: 6, including 2 Major and 2 that have been waiting more than a month. (One issue is in both categories.)
benjifisher NR: 27, including 7 that have been waiting more than a month and 4 Major
benjifisher That represents a lot of progress since last week.

4️⃣ How can I help? Comment in this thread if you are looking for ways to help. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...

quietone no discussion

5️⃣ Invalid migrations being ignored by the migrate process plugin: migration_lookup

benjifisher #3143486: Invalid migrations being ignored by the migrate process plugin: migration_lookup
benjifisher Is this a duplicate of #2744323: MigrationPluginManager::createInstance() doesn't throw an exception when failing to create an instance? If so, should we close one as a duplicate? Should the remaining issue be Major?
benjifisher @quietone, you are the one who marked the newer issue as NR and linked to a few other issues. Do you think we should make this one a meta for all the related issues>
quietone Good idea. I can do that.
quietone New meta, #3192870: [Meta] What to do when a migration can not be created

6️⃣ Update Migrate Tools for Drush 10.4

benjifisher https://gitlab.com/drupalspoons/migrate_tools/-/issues/118
benjifisher I wanted to work on this issue, but have not yet started.

7️⃣ Should we make a new community initiative for migration? (edited) 

benjifisher We discussed this at last week's meeting (#3189805: [meeting] Migrate Meeting 2021-01-07). @mikelutz (he/him), any opinion?
quietone +1. I like the idea of Drupal 9 compatibility (for a defined set of modules) as being a goal.
mikelutz (he/him) I mean it's basically semantics, isn't it? We wouldn't be changing what we are doing.
benjifisher Also advertising. We would get listed on https://www.drupal.org/community-initiatives.
quietone And if I were an admin/dev out there, particularly one just getting started with migrate, I would be glad the initiative exists. It lets me know that the community knows this is a challenging task and are actively working on it.
mikelutz (he/him) Alright, well let's phrase it like "should we make a new community initiative for migrate" not, "reopen the migrate initiative" because the old core initiative is a completely different thing than a community initiative.
benjifisher I can edit that ...
Matroskeen I like the idea. Although the Migrate API is great, there is still plenty of stuff to do
mikelutz (he/him) My gut reaction to "should we reopen" was hell no. We put way to much work in to finish it, lol

8️⃣ migrate mapping & messages table names are truncated, can lead to incorrect mapping lookups

benjifisher #2845340: migrate mapping & messages table names are truncated, can lead to incorrect mapping lookups
benjifisher The remaining question for that issue is how toHandle the change of migrate table names in a BC friendly wayI think we need an update function toLoop through all migration plugins;Calculate the table names under the old and new systems.When different, update the table name.Is that last step possible or do we have to create, copy, and delete?
quietone Thanks. That is exactly what I wanted confirmation on, that the update hook is needed. I am not sure about the last step either but I will soon.
benjifisher https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Database%...
benjifisher And https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Database%... to get a Schema object.
benjifisher Completely untested by me. :wink:

9️⃣ [META] Drupal 7 to Drupal 8 Migration path

benjifisher #2456259: [META] Drupal 7 to Drupal 8 Migration path
quietone These are remaining issues to complete the D7 migration path. Two of the three are at NR.
quietone Can anyone review those issues?
benjifisher #2814953 was originally RTBC in Comment #59. Since then, there have been a few re-rolls, and I have reviewed those. I should be able to review the latest one.
benjifisher The other one is #3051252: Upgrade path for Multiupload Filefield Widget and Multiupload Imagefield Widget. I have not looked at it. Any volunteers?

1️⃣0️⃣ Create a way to declare a plugin as deprecated

benjifisher #3039240: Create a way to declare a plugin as deprecated
benjifisher @quietone, your latest comment on the issue in 8️⃣ is that we do not need to postpone it on this issue.I guess we need to resolve this before we can start thinking about removing the D6 source plugins.
quietone Yes, and this is not part of #3118154: [meta] Deprecate dependencies, libraries, modules, and themes that will be removed from Drupal 10 core by 9.4.0-beta1 which is to do the deprecations by 9.2.0-beta1
quietone In other words,  it needs more people working on it.
benjifisher 9.2.0-beta1 is scheduled for mid May. I guess that is the deadline for deprecating anything to be removed in Drupal 10.

1️⃣1️⃣ Migrate booster

benjifisher https://www.drupal.org/sandbox/onkeltem/2828817
benjifisher Sandbox project.
dinarcon A similar feature was available in migrate core in Drupal 7. Does it make sense to bring this to core?

1️⃣2️⃣ Wrap up

benjifisher Thanks for participating! I will update 2️⃣. Please continue to add comments in the threads. In 1-7 days, we will post a transcript for today's meeting.
quietone @benjifisher, thank you for facilitating!

Participants:

benjifisher, quietone, mikelutz (he/him), Matroskeen, dinarcon

Comments

benjifisher created an issue. See original summary.

quietone’s picture

Issue summary: View changes

Added an Agenda Items section in the IS for everyone to add agenda items.

quietone’s picture

Didn't get discussed as planned in previous meeting so re-adding benjifisher's comment #3143486#6 here.

I think we should discuss #3143486: Invalid migrations being ignored by the migrate process plugin: migration_lookup, #2744323: MigrationPluginManager::createInstance() doesn't throw an exception when failing to create an instance and related issues.

quietone credited dinarcon.

quietone credited mikelutz.

quietone’s picture

Issue summary: View changes
quietone’s picture

Issue summary: View changes
quietone’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.